From 184da8907ed0803e51c9757573c6f452dd760f28 Mon Sep 17 00:00:00 2001 From: Jakub Romanczyk Date: Wed, 27 Nov 2024 10:39:39 -0800 Subject: [PATCH] refactor(community-cli-plugin): use node builtin fetch (#47397) Summary: Removed `node-fetch` in favour of node builtin fetch to get rid of the deprecated `punycode` warning when using Node 22. `react-native/community-cli-plugin` already requires Node >= 18 where it was made available by default (without `--experimental-fetch` flag). This change is similar to the one made in https://github.com/facebook/react-native/pull/45227 ## Changelog: [GENERAL] [CHANGED] - Drop node-fetch in favor of Node's built-in fetch from undici in `react-native/community-cli-plugin` Pull Request resolved: https://github.com/facebook/react-native/pull/47397 Test Plan: tests pass Reviewed By: blakef Differential Revision: D66512595 Pulled By: NickGerleman fbshipit-source-id: c4e01baf388f9fae8cea7b4bfe25034bff28b461 --- packages/community-cli-plugin/package.json | 1 - .../src/commands/start/OpenDebuggerKeyboardHandler.js | 1 - packages/community-cli-plugin/src/utils/isDevServerRunning.js | 1 - 3 files changed, 3 deletions(-) diff --git a/packages/community-cli-plugin/package.json b/packages/community-cli-plugin/package.json index 3b29dd0ce08..54fc02041b8 100644 --- a/packages/community-cli-plugin/package.json +++ b/packages/community-cli-plugin/package.json @@ -30,7 +30,6 @@ "metro": "^0.81.0", "metro-config": "^0.81.0", "metro-core": "^0.81.0", - "node-fetch": "^2.2.0", "readline": "^1.3.0", "semver": "^7.1.3" }, diff --git a/packages/community-cli-plugin/src/commands/start/OpenDebuggerKeyboardHandler.js b/packages/community-cli-plugin/src/commands/start/OpenDebuggerKeyboardHandler.js index 1954f289e08..c45888dba79 100644 --- a/packages/community-cli-plugin/src/commands/start/OpenDebuggerKeyboardHandler.js +++ b/packages/community-cli-plugin/src/commands/start/OpenDebuggerKeyboardHandler.js @@ -12,7 +12,6 @@ import type TerminalReporter from 'metro/src/lib/TerminalReporter'; import chalk from 'chalk'; -import fetch from 'node-fetch'; type PageDescription = $ReadOnly<{ id: string, diff --git a/packages/community-cli-plugin/src/utils/isDevServerRunning.js b/packages/community-cli-plugin/src/utils/isDevServerRunning.js index 7f154afd079..0d4cbe7aa75 100644 --- a/packages/community-cli-plugin/src/utils/isDevServerRunning.js +++ b/packages/community-cli-plugin/src/utils/isDevServerRunning.js @@ -10,7 +10,6 @@ */ import net from 'net'; -import fetch from 'node-fetch'; /** * Determine whether we can run the dev server.