From 173b65803d02187f53cb9956b85d2f72f8e71b98 Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Mon, 16 Dec 2024 05:54:38 -0800 Subject: [PATCH] Store backfaceVisibility as boolean (#48268) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48268 No need to store and compare strings here when a simple boolean will do. Changelog: [Internal] Reviewed By: NickGerleman, mdvacca Differential Revision: D67204387 fbshipit-source-id: c78cc758797980c2bce11875e0f6ea1961058f05 --- .../com/facebook/react/views/view/ReactViewGroup.java | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java index a245f7ffae2..16904ce7d02 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewGroup.java @@ -137,7 +137,7 @@ public class ReactViewGroup extends ViewGroup private boolean mNeedsOffscreenAlphaCompositing; private @Nullable ViewGroupDrawingOrderHelper mDrawingOrderHelper; private float mBackfaceOpacity; - private String mBackfaceVisibility; + private boolean mBackfaceVisible; private @Nullable Set mChildrenRemovedWhileTransitioning; /** @@ -172,7 +172,7 @@ public class ReactViewGroup extends ViewGroup mNeedsOffscreenAlphaCompositing = false; mDrawingOrderHelper = null; mBackfaceOpacity = 1.f; - mBackfaceVisibility = "visible"; + mBackfaceVisible = true; mChildrenRemovedWhileTransitioning = null; } @@ -989,14 +989,12 @@ public class ReactViewGroup extends ViewGroup } public void setBackfaceVisibility(String backfaceVisibility) { - mBackfaceVisibility = backfaceVisibility; + mBackfaceVisible = "visible".equals(backfaceVisibility); setBackfaceVisibilityDependantOpacity(); } public void setBackfaceVisibilityDependantOpacity() { - boolean isBackfaceVisible = mBackfaceVisibility.equals("visible"); - - if (isBackfaceVisible) { + if (mBackfaceVisible) { setAlpha(mBackfaceOpacity); return; }