From 16efb8dd520b752eb04c2807583fa1f4df279966 Mon Sep 17 00:00:00 2001
From: Luna Wei <luwe@fb.com>
Date: Tue, 9 Feb 2021 11:57:31 -0800
Subject: [PATCH] Render test titles and standardize on output

Summary:
Changelog:
[General][Added] - Show a test title if set and standardize the output

Note this will break existing screenshot tests so will need to re-run these

Reviewed By: nadiia

Differential Revision: D26318844

fbshipit-source-id: cef48d72a524ccc6f32b9d930c68fe4171270365
---
 .../js/components/RNTesterExampleContainer.js |  2 +-
 .../SectionList/SectionListExamples.js        | 30 ++++++++++---------
 .../SectionList/SectionList_onEndReached.js   |  6 ++--
 .../SectionList_onViewableItemsChanged.js     |  4 ++-
 packages/rn-tester/js/types/RNTesterTypes.js  |  1 +
 5 files changed, 25 insertions(+), 18 deletions(-)

diff --git a/packages/rn-tester/js/components/RNTesterExampleContainer.js b/packages/rn-tester/js/components/RNTesterExampleContainer.js
index ad2501c3111..744c4bb89a9 100644
--- a/packages/rn-tester/js/components/RNTesterExampleContainer.js
+++ b/packages/rn-tester/js/components/RNTesterExampleContainer.js
@@ -55,7 +55,7 @@ class RNTesterExampleContainer extends React.Component {
     if (module.examples.length === 1) {
       return (
         <ExamplePage
-          title={module.title}
+          title={module.testTitle || module.title}
           description={module.description}
           android={!module.platform || module.platform === 'android'}
           ios={!module.platform || module.platform === 'ios'}
diff --git a/packages/rn-tester/js/examples/SectionList/SectionListExamples.js b/packages/rn-tester/js/examples/SectionList/SectionListExamples.js
index 4d8f20bb2d2..2ac03d62155 100644
--- a/packages/rn-tester/js/examples/SectionList/SectionListExamples.js
+++ b/packages/rn-tester/js/examples/SectionList/SectionListExamples.js
@@ -8,7 +8,7 @@
  * @format
  */
 
-import {Pressable, SectionList, StyleSheet, Text, View} from 'react-native';
+import {Button, SectionList, StyleSheet, Text, View} from 'react-native';
 import * as React from 'react';
 
 type Props = {
@@ -62,7 +62,7 @@ function getExample(example, output, ref) {
             ),
           viewabilityConfig: VIEWABILITY_CONFIG,
         },
-        startTest: () => {},
+        onTest: null,
       };
 
     case 'onEndReached':
@@ -71,7 +71,7 @@ function getExample(example, output, ref) {
           onEndReached: info => output('onEndReached'),
           onEndReachedThreshold: 0,
         },
-        startTest: () => {
+        onTest: () => {
           const scrollResponder = ref?.current?.getScrollResponder();
           if (scrollResponder != null) {
             scrollResponder.scrollToEnd();
@@ -86,18 +86,14 @@ function getExample(example, output, ref) {
 function SectionListExamples(props: Props): React.Node {
   const [output, setOutput] = React.useState('');
   const ref = React.useRef<?React.ElementRef<typeof SectionList>>();
-  const {startTest, props: testProps} = getExample(
-    props.example,
-    setOutput,
-    ref,
-  );
+  const {onTest, props: testProps} = getExample(props.example, setOutput, ref);
   return (
     <View>
-      <View testID="test_container" style={styles.row}>
+      <View testID="test_container" style={styles.testContainer}>
         <Text testID="output">{output}</Text>
-        <Pressable testID="start_test" onPress={startTest}>
-          <Text>Test</Text>
-        </Pressable>
+        {onTest != null ? (
+          <Button testID="start_test" onPress={onTest} title="Test" />
+        ) : null}
       </View>
       <SectionList
         ref={ref}
@@ -129,9 +125,15 @@ const styles = StyleSheet.create({
     fontSize: 24,
   },
   sectionList: {height: '90%'},
-  row: {
+  testContainer: {
     flexDirection: 'row',
-    height: '10%',
+    justifyContent: 'space-between',
+    alignItems: 'center',
+    backgroundColor: '#f2f2f7ff',
+    padding: 10,
+  },
+  output: {
+    fontSize: 12,
   },
 });
 
diff --git a/packages/rn-tester/js/examples/SectionList/SectionList_onEndReached.js b/packages/rn-tester/js/examples/SectionList/SectionList_onEndReached.js
index 085a17682b6..14a36c6e530 100644
--- a/packages/rn-tester/js/examples/SectionList/SectionList_onEndReached.js
+++ b/packages/rn-tester/js/examples/SectionList/SectionList_onEndReached.js
@@ -13,12 +13,14 @@ import SectionListExamples from './SectionListExamples';
 const React = require('react');
 
 exports.title = 'SectionList onEndReached';
+exports.testTitle = 'Test onEndReached callback';
 exports.category = 'ListView';
 exports.documentationURL = 'https://reactnative.dev/docs/sectionlist';
-exports.description = 'Showcase viewability config callback.';
+exports.description =
+  'Scroll to end of list or tap Test button to see `onEndReached` triggered.';
 exports.examples = [
   {
-    title: 'Simple scrollable list',
+    title: '',
     render: function(): React.Element<typeof SectionListExamples> {
       return <SectionListExamples example="onEndReached" />;
     },
diff --git a/packages/rn-tester/js/examples/SectionList/SectionList_onViewableItemsChanged.js b/packages/rn-tester/js/examples/SectionList/SectionList_onViewableItemsChanged.js
index 608ff366ed3..0c75b0cb70f 100644
--- a/packages/rn-tester/js/examples/SectionList/SectionList_onViewableItemsChanged.js
+++ b/packages/rn-tester/js/examples/SectionList/SectionList_onViewableItemsChanged.js
@@ -13,9 +13,11 @@ import SectionListExamples from './SectionListExamples';
 const React = require('react');
 
 exports.title = 'SectionList onViewableItemsChanged';
+exports.testTitle = 'Test onViewableItemsChanged callback';
 exports.category = 'ListView';
 exports.documentationURL = 'https://reactnative.dev/docs/sectionlist';
-exports.description = 'Showcase viewability config callback.';
+exports.description =
+  'Scroll list to see what items are returned in `onViewableItemsChanged` callback.';
 exports.examples = [
   {
     title: 'Simple scrollable list',
diff --git a/packages/rn-tester/js/types/RNTesterTypes.js b/packages/rn-tester/js/types/RNTesterTypes.js
index 2c86c550fbb..3088829d09c 100644
--- a/packages/rn-tester/js/types/RNTesterTypes.js
+++ b/packages/rn-tester/js/types/RNTesterTypes.js
@@ -20,6 +20,7 @@ export type RNTesterExampleModuleItem = $ReadOnly<{|
 
 export type RNTesterExampleModule = $ReadOnly<{|
   title: string,
+  testTitle?: ?string,
   description: string,
   displayName?: ?string,
   documentationURL?: ?string,