From 14ecdcfdd4f4eb2ecc33ea575d077423955dcf48 Mon Sep 17 00:00:00 2001 From: CodemodService Bot Date: Thu, 4 Sep 2025 01:58:43 -0700 Subject: [PATCH] Fix CQS signal readability-implicit-bool-conversion in xplat/js/react-native-github/packages Reviewed By: rshest Differential Revision: D81569365 --- .../React/Fabric/Mounting/RCTComponentViewFactory.mm | 6 +++--- .../React/Fabric/Utils/PlatformRunLoopObserver.mm | 2 +- packages/react-native/React/Fabric/Utils/RCTBoxShadow.mm | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/react-native/React/Fabric/Mounting/RCTComponentViewFactory.mm b/packages/react-native/React/Fabric/Mounting/RCTComponentViewFactory.mm index 6f7cc61a8e7..c696184983f 100644 --- a/packages/react-native/React/Fabric/Mounting/RCTComponentViewFactory.mm +++ b/packages/react-native/React/Fabric/Mounting/RCTComponentViewFactory.mm @@ -132,18 +132,18 @@ static Class RCTComponentViewClassWithName(const char // Fallback 1: Call provider function for component view class. Class klass = RCTComponentViewClassWithName(name.c_str()); - if (klass) { + if (klass != nullptr) { [self registerComponentViewClass:klass]; return; } // Fallback 2: Ask the provider and check in the dictionary provided - if (self.thirdPartyFabricComponentsProvider) { + if (self.thirdPartyFabricComponentsProvider != nullptr) { // Test whether a provider has been passed to avoid potentially expensive conversions // between C++ and ObjC strings. NSString *objcName = [NSString stringWithCString:name.c_str() encoding:NSUTF8StringEncoding]; klass = self.thirdPartyFabricComponentsProvider.thirdPartyFabricComponents[objcName]; - if (klass) { + if (klass != nullptr) { [self registerComponentViewClass:klass]; return; } diff --git a/packages/react-native/React/Fabric/Utils/PlatformRunLoopObserver.mm b/packages/react-native/React/Fabric/Utils/PlatformRunLoopObserver.mm index 65f48b48a4f..c11d48cdb17 100644 --- a/packages/react-native/React/Fabric/Utils/PlatformRunLoopObserver.mm +++ b/packages/react-native/React/Fabric/Utils/PlatformRunLoopObserver.mm @@ -54,7 +54,7 @@ PlatformRunLoopObserver::PlatformRunLoopObserver( mainRunLoopObserver_ = CFRunLoopObserverCreateWithHandler( NULL /* allocator */, toCFRunLoopActivity(activities_) /* activities */, - true /* repeats */, + 1u /* repeats */, 0 /* order */, ^(CFRunLoopObserverRef observer, CFRunLoopActivity activity) { auto strongOwner = owner.lock(); diff --git a/packages/react-native/React/Fabric/Utils/RCTBoxShadow.mm b/packages/react-native/React/Fabric/Utils/RCTBoxShadow.mm index 54f3b79894c..54633558d17 100644 --- a/packages/react-native/React/Fabric/Utils/RCTBoxShadow.mm +++ b/packages/react-native/React/Fabric/Utils/RCTBoxShadow.mm @@ -50,7 +50,7 @@ static CGRect insetRect(CGRect rect, CGFloat left, CGFloat top, CGFloat right, C static CGColorRef colorRefFromSharedColor(const SharedColor &color) { CGColorRef colorRef = RCTUIColorFromSharedColor(color).CGColor; - return colorRef ? colorRef : [UIColor blackColor].CGColor; + return (colorRef != nullptr) ? colorRef : [UIColor blackColor].CGColor; } static CALayer *initBoxShadowLayer(const BoxShadow &shadow, CGSize layerSize)