From 14c869cee6ec56c649bd59e03545603ec2674d18 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rub=C3=A9n=20Norte?= Date: Tue, 5 Aug 2025 07:06:24 -0700 Subject: [PATCH] Reduce side-effects of AppRegistry (#53054) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/53054 Changelog: [internal] We eagerly require `AppRegistry` from environment initialization (`InitializeCore`) because it has some side-effects that are necessary for error reporting (see https://github.com/facebook/react-native/issues/34649 and https://github.com/facebook/react-native/pull/34650), but this change makes a lot of modules to be eagerly initialized. This reduces that to avoid loading modules that not necessary for environment setup, which allows us to do things like setting up feature flags before modules like `View` and `Text` have been initialized. Reviewed By: rshest Differential Revision: D79636159 fbshipit-source-id: a3f1e0db3dd69112ceef3ea339167694e2457454 --- .../react-native/Libraries/ReactNative/AppRegistryImpl.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/react-native/Libraries/ReactNative/AppRegistryImpl.js b/packages/react-native/Libraries/ReactNative/AppRegistryImpl.js index 8f8db1cde94..2fe95f88970 100644 --- a/packages/react-native/Libraries/ReactNative/AppRegistryImpl.js +++ b/packages/react-native/Libraries/ReactNative/AppRegistryImpl.js @@ -26,8 +26,6 @@ import createPerformanceLogger from '../Utilities/createPerformanceLogger'; import SceneTracker from '../Utilities/SceneTracker'; import {coerceDisplayMode} from './DisplayMode'; import HeadlessJsTaskError from './HeadlessJsTaskError'; -import NativeHeadlessJsTaskSupport from './NativeHeadlessJsTaskSupport'; -import renderApplication from './renderApplication'; import {unmountComponentAtNodeAndRemoveContainer} from './RendererProxy'; import invariant from 'invariant'; @@ -86,6 +84,7 @@ export function registerComponent( ): string { const scopedPerformanceLogger = createPerformanceLogger(); runnables[appKey] = (appParameters, displayMode) => { + const renderApplication = require('./renderApplication').default; renderApplication( componentProviderInstrumentationHook( componentProvider, @@ -258,6 +257,9 @@ export function startHeadlessTask( taskKey: string, data: any, ): void { + const NativeHeadlessJsTaskSupport = + require('./NativeHeadlessJsTaskSupport').default; + const taskProvider = taskProviders.get(taskKey); if (!taskProvider) { console.warn(`No task registered for key ${taskKey}`);