From 14b2b1ce50fc59ffbfbe35dee417c28bded94d69 Mon Sep 17 00:00:00 2001
From: Blake Friedman <blakef@meta.com>
Date: Mon, 24 Apr 2023 04:47:03 -0700
Subject: [PATCH] investigating cause of ReactViewManager returning null

Summary:
Throws and captures the overloading class as well as the component name to help us track.

[Android][Changed] - Added an exception, which will be removed shortly.

Reviewed By: cortinico

Differential Revision: D45185598

fbshipit-source-id: 222a38be12c0a41774c83b657a4e4134ce9c197f
---
 .../views/view/ReactViewManagerWrapper.kt     | 21 ++++++++++++++++---
 1 file changed, 18 insertions(+), 3 deletions(-)

diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManagerWrapper.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManagerWrapper.kt
index 0a349409f76..f99677b1703 100644
--- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManagerWrapper.kt
+++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ReactViewManagerWrapper.kt
@@ -16,6 +16,9 @@ import com.facebook.react.uimanager.StateWrapper
 import com.facebook.react.uimanager.ThemedReactContext
 import com.facebook.react.uimanager.ViewManager
 
+/** Temporary to help trace the cause of T151032868 */
+class ReactViewReturnTypeException(message: String) : Exception(message)
+
 interface ReactViewManagerWrapper {
   fun createView(
       reactTag: Int,
@@ -51,9 +54,21 @@ interface ReactViewManagerWrapper {
         props: Any?,
         stateWrapper: StateWrapper?,
         jsResponderHandler: JSResponderHandler
-    ): View =
-        viewManager.createView(
-            reactTag, reactContext, props as? ReactStylesDiffMap, stateWrapper, jsResponderHandler)
+    ): View {
+      val manager =
+          viewManager.createView(
+              reactTag,
+              reactContext,
+              props as? ReactStylesDiffMap,
+              stateWrapper,
+              jsResponderHandler)
+      // Throwing to try capture information about the cause of T151032868, remove after.
+      if (manager == null) {
+        throw ReactViewReturnTypeException(
+            "DefaultViewManagerWrapper::createView(${viewManager.getName()}, ${viewManager::class.java}) can't return null")
+      }
+      return manager
+    }
 
     override fun updateProperties(viewToUpdate: View, props: Any?) {
       viewManager.updateProperties(viewToUpdate, props as? ReactStylesDiffMap)