diff --git a/packages/react-native/ReactCxxPlatform/react/renderer/animated/AnimatedModule.cpp b/packages/react-native/ReactCxxPlatform/react/renderer/animated/AnimatedModule.cpp index 43f3fa3ec11..b3392206580 100644 --- a/packages/react-native/ReactCxxPlatform/react/renderer/animated/AnimatedModule.cpp +++ b/packages/react-native/ReactCxxPlatform/react/renderer/animated/AnimatedModule.cpp @@ -56,7 +56,9 @@ void AnimatedModule::updateAnimatedNodeConfig( jsi::Runtime& rt, Tag tag, jsi::Object config) { - // TODO(T196513045): missing implementation + // TODO(T196513045): missing implementation. This API is only used by Animated + // when PlatformColor API is used and animation is updated with a new value + // through AnimatedColor.setValue. } void AnimatedModule::getValue( @@ -191,11 +193,15 @@ void AnimatedModule::removeAnimatedEventFromView( void AnimatedModule::addListener( jsi::Runtime& /*rt*/, const std::string& /*eventName*/) { - // TODO(T225953415): missing implementation + // Not needed in C++ Animated. addListener is used to synchronise event + // animations like onScroll with React and Fabric. However C++ Animated + // synchronises with Fabric directly. } void AnimatedModule::removeListeners(jsi::Runtime& /*rt*/, int /*count*/) { - // TODO(T225953457): missing implementation + // Not needed in C++ Animated. removeListeners is used to synchronise event + // animations like onScroll with React and Fabric. However C++ Animated + // synchronises with Fabric directly. } void AnimatedModule::queueAndExecuteBatchedOperations( diff --git a/packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.cpp b/packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.cpp index 53ebb05e07c..1a457fc07e7 100644 --- a/packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.cpp +++ b/packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.cpp @@ -87,7 +87,7 @@ std::optional NativeAnimatedNodesManager::getValue(Tag tag) noexcept { } } -// graph +#pragma mark - Graph std::unique_ptr NativeAnimatedNodesManager::animatedNode( Tag tag, @@ -235,7 +235,7 @@ void NativeAnimatedNodesManager::dropAnimatedNode(Tag tag) noexcept { animatedNodes_.erase(tag); } -// mutations +#pragma mark - Mutations void NativeAnimatedNodesManager::setAnimatedNodeValue(Tag tag, double value) { if (auto node = getAnimatedNode(tag)) { @@ -280,7 +280,7 @@ void NativeAnimatedNodesManager::stopAnimationsForNode(Tag nodeTag) { } } -// drivers +#pragma mark - Drivers void NativeAnimatedNodesManager::startAnimatingNode( int animationId, @@ -701,7 +701,8 @@ bool NativeAnimatedNodesManager::isOnRenderThread() const noexcept { return isOnRenderThread_; } -// listeners +#pragma mark - Listeners + void NativeAnimatedNodesManager::startListeningToAnimatedNodeValue( Tag tag, ValueListenerCallback&& callback) noexcept { diff --git a/packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.h b/packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.h index b19f9a83b43..1e2e532dfcc 100644 --- a/packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.h +++ b/packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.h @@ -78,7 +78,7 @@ class NativeAnimatedNodesManager { std::optional getValue(Tag tag) noexcept; - // graph +#pragma mark - Graph void createAnimatedNode(Tag tag, const folly::dynamic& config) noexcept; @@ -102,7 +102,7 @@ class NativeAnimatedNodesManager { void setAnimatedNodeOffset(Tag tag, double offset); - // drivers +#pragma mark - Drivers void startAnimatingNode( int animationId, @@ -127,7 +127,8 @@ class NativeAnimatedNodesManager { std::shared_ptr getEventEmitterListener() noexcept { return ensureEventEmitterListener(); } - // listeners + +#pragma mark - Listeners void startListeningToAnimatedNodeValue( Tag tag,