Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

round up layoutWidth for Android 11 in ReactTextShadowNode

Browse Source 
Summary:
in Android 11, there's an issue where Text content is being clipped. The root cause appears to be a breaking change in how Android 11 is measuring text. rounding up the layoutWidth calculation mitigates the issue.

Changelog: [Internal]

Reviewed By: JoshuaGross

Differential Revision: D23944772

fbshipit-source-id: 1639259da1c2c507c6bfc80fed377577316febac
This commit is contained in:
Michael Yoon (LAX)
2020-09-25 19:06:18 -07:00
committed by Facebook GitHub Bot
parent 920bd2c199
commit 1438543a2f
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextShadowNode.java
+3
View File
@@ -144,6 +144,9 @@ public class ReactTextShadowNode extends ReactBaseTextShadowNode {
}
}
if (android.os.Build.VERSION.SDK_INT > android.os.Build.VERSION_CODES.Q) {
layoutWidth = (float) Math.ceil(layoutWidth);
}
float layoutHeight = height;
if (heightMode != YogaMeasureMode.EXACTLY) {
layoutHeight = layout.getLineBottom(lineCount - 1);