From 13db1cb88bdd454cf19be358d6f0cd62f5a6d0cc Mon Sep 17 00:00:00 2001 From: Marlene Cota <1422161+marlenecota@users.noreply.github.com> Date: Thu, 12 Sep 2024 07:27:52 -0700 Subject: [PATCH] Fix double to float type conversion error (#46447) Summary: ![image](https://github.com/user-attachments/assets/3808e1ec-7b56-4cc6-85fb-a48beceba519) ## Changelog: [GENERAL] [FIXED] - Fix type conversion error in react native windows build. Pull Request resolved: https://github.com/facebook/react-native/pull/46447 Test Plan: RNW CI builds. Reviewed By: cipolleschi Differential Revision: D62570270 Pulled By: cortinico fbshipit-source-id: da3da297ba10cdd41f49e754ce52053055d61644 --- .../react/renderer/core/LayoutableShadowNode.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp b/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp index c13b2aed97f..86e78064cb6 100644 --- a/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp +++ b/packages/react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp @@ -279,8 +279,8 @@ ShadowNode::Shared LayoutableShadowNode::findNodeAtPoint( auto centerY = transformedFrame.origin.y + transformedFrame.size.height / 2.0; - auto relativeX = float(point.x - centerX); - auto relativeY = float(point.y - centerY); + auto relativeX = point.x - centerX; + auto relativeY = point.y - centerY; if (Transform::isVerticalInversion(transform)) { relativeY = -relativeY; @@ -289,8 +289,8 @@ ShadowNode::Shared LayoutableShadowNode::findNodeAtPoint( relativeX = -relativeX; } - point.x = centerX + relativeX; - point.y = centerY + relativeY; + point.x = float(centerX + relativeX); + point.y = float(centerY + relativeY); } auto newPoint = point - transformedFrame.origin -