From 10beefbbfadcbe6e40314564e409bf592a16e571 Mon Sep 17 00:00:00 2001 From: Lorenzo Sciandra Date: Wed, 28 Jun 2023 15:30:42 +0100 Subject: [PATCH] [LOCAL] reapply "Set kotlin.jvm.target.validation.mode=warning on user projects" by Nicola --- .../kotlin/com/facebook/react/utils/JdkConfiguratorUtils.kt | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/JdkConfiguratorUtils.kt b/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/JdkConfiguratorUtils.kt index 78fe1b6a13b..a18f2b67315 100644 --- a/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/JdkConfiguratorUtils.kt +++ b/packages/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/JdkConfiguratorUtils.kt @@ -36,5 +36,11 @@ internal object JdkConfiguratorUtils { project.pluginManager.withPlugin("com.android.application", action) project.pluginManager.withPlugin("com.android.library", action) } + // We set kotlin.jvm.target.validation.mode=warning on the root projects, as for projects + // on Gradle 8+ and Kotlin 1.8+ this value is set to `error`. This will cause the build to + // fail if the JDK version between compileKotlin and compileJava and jvmTarget are not + // aligned. This won't be necessary anymore from React Native 0.73. More on this: + // https://kotlinlang.org/docs/whatsnew18.html#obligatory-check-for-jvm-targets-of-related-kotlin-and-java-compile-tasks + input.rootProject.extensions.extraProperties.set("kotlin.jvm.target.validation.mode", "warning") } }