Transform BubbleEvent and DirectEvent into DirectEventHandler and BubblingEventHandler

Summary:
It appears that `(e: BubblingEvent<T>) = mixed` exists only in given context and it's pointless to keep in this way. It could be simplified to `BubblingEventHandler<T>` without any negative consequences and that's the motivation of this diff.

The only tradeoff of this decision is leaving an opportunity to declare Bubbling/Direct event in the top of the file bc then analysing the code becomes much more difficult. However, it's not used anywhere so it's not a problem now and probably any time.

Also, changes the names to `DirectEventHandler` and `BubblingEventHandler` which are more related to current state. The names were updated in many places in code.

Reviewed By: rubennorte

Differential Revision: D16054571

fbshipit-source-id: 741d075eb46b80bac8eb73a6b30fc0b448cb3902
This commit is contained in:
Michał Osadnik
2019-07-01 05:13:53 -07:00
committed by Facebook Github Bot
parent 58d87940a1
commit 0f83dfab8e
19 changed files with 150 additions and 2729 deletions
@@ -11,15 +11,17 @@
import codegenNativeComponent from '../../Utilities/codegenNativeComponent';
import type {ViewProps} from '../View/ViewPropTypes';
import type {BubblingEvent, WithDefault, Int32} from '../../Types/CodegenTypes';
import type {
BubblingEventHandler,
WithDefault,
Int32,
} from '../../Types/CodegenTypes';
import type {ColorValue} from '../../StyleSheet/StyleSheetTypes';
export type OnChangeEvent = BubblingEvent<
$ReadOnly<{|
value: Int32,
selectedSegmentIndex: Int32,
|}>,
>;
export type OnChangeEvent = $ReadOnly<{|
value: Int32,
selectedSegmentIndex: Int32,
|}>;
type NativeProps = $ReadOnly<{|
...ViewProps,
@@ -32,7 +34,7 @@ type NativeProps = $ReadOnly<{|
momentary?: ?WithDefault<boolean, false>,
// Events
onChange?: ?(event: OnChangeEvent) => mixed,
onChange?: ?BubblingEventHandler<OnChangeEvent>,
|}>;
export default codegenNativeComponent<NativeProps>('RCTSegmentedControl');