Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fabric: MountingCoordinator - the new way to ensure ordering of mount transaction

Browse Source 
Summary:
TBD.
This thing fixes flickering during appearing of Fabric screens on iOS.

Reviewed By: mdvacca

Differential Revision: D15116079

fbshipit-source-id: 95ed0ba94667cad67fe4317025128d01b34f69c5
This commit is contained in:
Valentin Shergin
2019-05-03 15:11:35 -07:00
committed by Facebook Github Bot
parent 4803cab8c4
commit 0f2a09d1f6
21 changed files with 343 additions and 220 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/jni/Binding.cpp
+10 -4
View File
@@ -353,12 +353,18 @@ local_ref<JMountItem::javaobject> createCreateMountItem(
}
void Binding::schedulerDidFinishTransaction(
MountingTransaction &&mountingTransaction) {
MountingCoordinator::Shared const &mountingCoordinator) {
SystraceSection s("FabricUIManager::schedulerDidFinishTransaction");
auto telemetry = mountingTransaction.getTelemetry();
auto mutations = mountingTransaction.getMutations();
auto surfaceId = mountingTransaction.getSurfaceId();
auto mountingTransaction = mountingCoordinator->pullTransaction();
if (!mountingTransaction.has_value()) {
return;
}
auto telemetry = mountingTransaction->getTelemetry();
auto surfaceId = mountingTransaction->getSurfaceId();
auto &mutations = mountingTransaction->getMutations();
std::vector<local_ref<jobject>> queue;
// Upper bound estimation of mount items to be delivered to Java side.
ReactAndroid/src/main/java/com/facebook/react/fabric/jsi/jni/Binding.h
+1 -1
View File
@@ -57,7 +57,7 @@ class Binding : public jni::HybridClass<Binding>, public SchedulerDelegate {
void stopSurface(jint surfaceId);
void schedulerDidFinishTransaction(
MountingTransaction &&mountingTransaction);
MountingCoordinator::Shared const &mountingCoordinator);
void schedulerDidRequestPreliminaryViewAllocation(
const SurfaceId surfaceId,