Update the chrome devtools protocol for the inspector

Summary:
Changelog: [Internal] Upgrade Chrome devtools protocol for Hermes

Update to the most recent version of the devtools protocol, r730699.
This just adds a few parameters to the stable API.
They have reasonable defaults that shouldn't break the existing functionality.

Reviewed By: willholen

Differential Revision: D19387559

fbshipit-source-id: 49d9ebf4a1a20f349ea6e46be6d5f36184ba8afb
This commit is contained in:
Riley Dulin
2020-01-15 16:52:19 -08:00
committed by Facebook Github Bot
parent 46351cc276
commit 0ee7fb98cc
4 changed files with 31 additions and 7 deletions
@@ -1,5 +1,5 @@
// Copyright 2004-present Facebook. All Rights Reserved.
// @generated SignedSource<<138b9ba90e2b7ed52d87874ad422df4b>>
// @generated SignedSource<<633984dcfe87d2822ef0e80c1aab93ef>>
#include "MessageTypes.h"
@@ -185,6 +185,7 @@ dynamic debugger::Scope::toDynamic() const {
debugger::CallFrame::CallFrame(const dynamic &obj) {
assign(callFrameId, obj, "callFrameId");
assign(functionName, obj, "functionName");
assign(functionLocation, obj, "functionLocation");
assign(location, obj, "location");
assign(url, obj, "url");
assign(scopeChain, obj, "scopeChain");
@@ -197,6 +198,7 @@ dynamic debugger::CallFrame::toDynamic() const {
put(obj, "callFrameId", callFrameId);
put(obj, "functionName", functionName);
put(obj, "functionLocation", functionLocation);
put(obj, "location", location);
put(obj, "url", url);
put(obj, "scopeChain", scopeChain);
@@ -341,6 +343,7 @@ debugger::EvaluateOnCallFrameRequest::EvaluateOnCallFrameRequest(
assign(includeCommandLineAPI, params, "includeCommandLineAPI");
assign(silent, params, "silent");
assign(returnByValue, params, "returnByValue");
assign(throwOnSideEffect, params, "throwOnSideEffect");
}
dynamic debugger::EvaluateOnCallFrameRequest::toDynamic() const {
@@ -351,6 +354,7 @@ dynamic debugger::EvaluateOnCallFrameRequest::toDynamic() const {
put(params, "includeCommandLineAPI", includeCommandLineAPI);
put(params, "silent", silent);
put(params, "returnByValue", returnByValue);
put(params, "throwOnSideEffect", throwOnSideEffect);
dynamic obj = dynamic::object;
put(obj, "id", id);
@@ -471,6 +475,7 @@ debugger::SetBreakpointByUrlRequest::SetBreakpointByUrlRequest(
assign(lineNumber, params, "lineNumber");
assign(url, params, "url");
assign(urlRegex, params, "urlRegex");
assign(scriptHash, params, "scriptHash");
assign(columnNumber, params, "columnNumber");
assign(condition, params, "condition");
}
@@ -480,6 +485,7 @@ dynamic debugger::SetBreakpointByUrlRequest::toDynamic() const {
put(params, "lineNumber", lineNumber);
put(params, "url", url);
put(params, "urlRegex", urlRegex);
put(params, "scriptHash", scriptHash);
put(params, "columnNumber", columnNumber);
put(params, "condition", condition);
@@ -592,11 +598,13 @@ heapProfiler::TakeHeapSnapshotRequest::TakeHeapSnapshotRequest(
dynamic params = obj.at("params");
assign(reportProgress, params, "reportProgress");
assign(treatGlobalObjectsAsRoots, params, "treatGlobalObjectsAsRoots");
}
dynamic heapProfiler::TakeHeapSnapshotRequest::toDynamic() const {
dynamic params = dynamic::object;
put(params, "reportProgress", reportProgress);
put(params, "treatGlobalObjectsAsRoots", treatGlobalObjectsAsRoots);
dynamic obj = dynamic::object;
put(obj, "id", id);
@@ -624,6 +632,7 @@ runtime::EvaluateRequest::EvaluateRequest(const dynamic &obj)
assign(silent, params, "silent");
assign(contextId, params, "contextId");
assign(returnByValue, params, "returnByValue");
assign(userGesture, params, "userGesture");
assign(awaitPromise, params, "awaitPromise");
}
@@ -635,6 +644,7 @@ dynamic runtime::EvaluateRequest::toDynamic() const {
put(params, "silent", silent);
put(params, "contextId", contextId);
put(params, "returnByValue", returnByValue);
put(params, "userGesture", userGesture);
put(params, "awaitPromise", awaitPromise);
dynamic obj = dynamic::object;
@@ -897,6 +907,9 @@ debugger::ScriptParsedNotification::ScriptParsedNotification(const dynamic &obj)
assign(hash, params, "hash");
assign(executionContextAuxData, params, "executionContextAuxData");
assign(sourceMapURL, params, "sourceMapURL");
assign(hasSourceURL, params, "hasSourceURL");
assign(isModule, params, "isModule");
assign(length, params, "length");
}
dynamic debugger::ScriptParsedNotification::toDynamic() const {
@@ -911,6 +924,9 @@ dynamic debugger::ScriptParsedNotification::toDynamic() const {
put(params, "hash", hash);
put(params, "executionContextAuxData", executionContextAuxData);
put(params, "sourceMapURL", sourceMapURL);
put(params, "hasSourceURL", hasSourceURL);
put(params, "isModule", isModule);
put(params, "length", length);
dynamic obj = dynamic::object;
put(obj, "method", method);
@@ -1,5 +1,5 @@
// Copyright 2004-present Facebook. All Rights Reserved.
// @generated SignedSource<<e953c14d4ad54968903d223038ab3f85>>
// @generated SignedSource<<16a6754d1896fef0cbab2a05800f6885>>
#pragma once
@@ -195,6 +195,7 @@ struct debugger::CallFrame : public Serializable {
debugger::CallFrameId callFrameId{};
std::string functionName;
folly::Optional<debugger::Location> functionLocation;
debugger::Location location{};
std::string url;
std::vector<debugger::Scope> scopeChain;
@@ -279,6 +280,7 @@ struct debugger::EvaluateOnCallFrameRequest : public Request {
folly::Optional<bool> includeCommandLineAPI;
folly::Optional<bool> silent;
folly::Optional<bool> returnByValue;
folly::Optional<bool> throwOnSideEffect;
};
struct debugger::PauseRequest : public Request {
@@ -328,6 +330,7 @@ struct debugger::SetBreakpointByUrlRequest : public Request {
int lineNumber{};
folly::Optional<std::string> url;
folly::Optional<std::string> urlRegex;
folly::Optional<std::string> scriptHash;
folly::Optional<int> columnNumber;
folly::Optional<std::string> condition;
};
@@ -374,6 +377,7 @@ struct heapProfiler::TakeHeapSnapshotRequest : public Request {
void accept(RequestHandler &handler) const override;
folly::Optional<bool> reportProgress;
folly::Optional<bool> treatGlobalObjectsAsRoots;
};
struct runtime::EvaluateRequest : public Request {
@@ -389,6 +393,7 @@ struct runtime::EvaluateRequest : public Request {
folly::Optional<bool> silent;
folly::Optional<runtime::ExecutionContextId> contextId;
folly::Optional<bool> returnByValue;
folly::Optional<bool> userGesture;
folly::Optional<bool> awaitPromise;
};
@@ -510,6 +515,9 @@ struct debugger::ScriptParsedNotification : public Notification {
std::string hash;
folly::Optional<folly::dynamic> executionContextAuxData;
folly::Optional<std::string> sourceMapURL;
folly::Optional<bool> hasSourceURL;
folly::Optional<bool> isModule;
folly::Optional<int> length;
};
struct heapProfiler::AddHeapSnapshotChunkNotification : public Notification {
@@ -32,7 +32,7 @@
}
},
"dependencies": {
"devtools-protocol": "0.0.511679",
"devtools-protocol": "0.0.730699",
"idx": "^2.1.0",
"yargs": "^14.2.0"
}
@@ -1907,10 +1907,10 @@ detect-newline@^2.1.0:
resolved "https://registry.yarnpkg.com/detect-newline/-/detect-newline-2.1.0.tgz#f41f1c10be4b00e87b5f13da680759f2c5bfd3e2"
integrity sha1-9B8cEL5LAOh7XxPaaAdZ8sW/0+I=
devtools-protocol@0.0.507347:
version "0.0.511679"
resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.511679.tgz#ed69e7138b0659a035c2d57d64d75aaa1e493352"
integrity sha512-6Gk8SbN5DgeazXWTwIS+peg9RJ9diIhqZKd80Q7Cz8cKAWpM0onp6ShhGwJozkxK/fDpWwC+gOYSY431UqkSTQ==
devtools-protocol@0.0.730699:
version "0.0.730699"
resolved "https://registry.yarnpkg.com/devtools-protocol/-/devtools-protocol-0.0.730699.tgz#4d18f6a9b7fb7cf3f1ffe73bfe14aad66cf3b2ef"
integrity sha512-dprBpuPzVIIXXL6GevzhvWe2wg836h3d5hY+n6IzzHbKLsUh6QlVmcIy15za0J3MhDFbmEH60s6uYsrw/tgBbw==
diff-sequences@^24.9.0:
version "24.9.0"