move NativeModuleRegistry creation logic into it's own class

Reviewed By: javache

Differential Revision: D4479604

fbshipit-source-id: 297fccd25c7400176bcb7821b644d9b05e465ffa
This commit is contained in:
Aaron Chiu authored and Facebook Github Bot committed 2017-01-30 06:43:48 -08:00
1 parent 919e49a8b8
commit 0e0a6e8a29
6 files changed
+197 -142

No files matched your search

@@ -36,18 +36,19 @@ public class ModuleHolder {
private @Nullable NativeModule mModule;
private boolean mInitializeNeeded;
public ModuleHolder(
Class<? extends NativeModule> clazz,
@Nullable ReactModuleInfo reactModuleInfo,
Provider<? extends NativeModule> provider) {
mInfo = reactModuleInfo == null ? new LegacyModuleInfo(clazz) : reactModuleInfo;
public ModuleHolder(ReactModuleInfo info, Provider<? extends NativeModule> provider) {
mInfo = info;
mProvider = provider;
if (mInfo.needsEagerInit()) {
mModule = doCreate();
}
}
public ModuleHolder(LegacyModuleInfo info, NativeModule nativeModule) {
mInfo = info;
mModule = nativeModule;
}
public synchronized void initialize() {
if (mModule != null) {
doInitialize(mModule);
@@ -139,29 +140,4 @@ public class ModuleHolder {
throw new RuntimeException(e);
}
}
private class LegacyModuleInfo implements Info {
public final Class<?> mType;
public LegacyModuleInfo(Class<?> type) {
mType = type;
}
public String name() {
return getModule().getName();
}
public boolean canOverrideExistingModule() {
return getModule().canOverrideExistingModule();
}
public boolean supportsWebWorkers() {
return getModule().supportsWebWorkers();
}
public boolean needsEagerInit() {
return true;
}
}
}