From 0d7b097cf94381bc2545f8795c48087875de0711 Mon Sep 17 00:00:00 2001
From: Blake Friedman <blake.friedman@gmail.com>
Date: Fri, 6 Dec 2024 12:36:14 +0000
Subject: [PATCH] [CI] Danger shouldn't warn for package.json changes

Someone always has to merge in from Meta, so this is just noise.
Refactored some of this older code.

Changelog: [Internal]

Test: This PR
---
 packages/react-native-bots/dangerfile.js | 50 +++++++++++++-----------
 1 file changed, 27 insertions(+), 23 deletions(-)

diff --git a/packages/react-native-bots/dangerfile.js b/packages/react-native-bots/dangerfile.js
index 2f7a7165e28..8323a9b6902 100644
--- a/packages/react-native-bots/dangerfile.js
+++ b/packages/react-native-bots/dangerfile.js
@@ -8,20 +8,31 @@
  */
 
 'use strict';
-const {danger, fail, /*message,*/ warn} = require('danger');
-const includes = require('lodash.includes');
+const {danger, fail, warn} = require('danger');
 
-const isFromPhabricator =
-  danger.github.pr.body &&
-  danger.github.pr.body.toLowerCase().includes('differential revision:');
+const body = danger.github.pr.body?.toLowerCase() ?? '';
+
+function body_contains(...text) {
+  for (const matcher of text) {
+    if (body.includes(matcher)) {
+      return true;
+    }
+  }
+  return false;
+}
+
+const isFromPhabricator = body_contains('differential revision:');
 
 // Provides advice if a summary section is missing, or body is too short
-const includesSummary =
-  danger.github.pr.body &&
-  danger.github.pr.body.toLowerCase().includes('## summary');
-if (!danger.github.pr.body || danger.github.pr.body.length < 50) {
+const includesSummary = body_contains('## summary', 'summary:');
+
+const hasNoUsefulBody =
+  !danger.github.pr.body || danger.github.pr.body.length < 50;
+const hasTooShortAHumanSummary =
+  !includesSummary && body.split('\n').length <= 2 && !isFromPhabricator;
+if (hasNoUsefulBody) {
   fail(':grey_question: This pull request needs a description.');
-} else if (!includesSummary && !isFromPhabricator) {
+} else if (hasTooShortAHumanSummary) {
   // PRs from Phabricator always includes the Summary by default.
   const title = ':clipboard: Missing Summary';
   const idea =
@@ -31,20 +42,13 @@ if (!danger.github.pr.body || danger.github.pr.body.length < 50) {
   warn(`${title} - <i>${idea}</i>`);
 }
 
-// Warns if there are changes to package.json, and tags the team.
-const packageChanged = includes(danger.git.modified_files, 'package.json');
-if (packageChanged) {
-  const title = ':lock: package.json';
-  const idea =
-    'Changes were made to package.json. ' +
-    'This will require a manual import by a Facebook employee.';
-  warn(`${title} - <i>${idea}</i>`);
-}
-
 // Provides advice if a test plan is missing.
-const includesTestPlan =
-  danger.github.pr.body &&
-  danger.github.pr.body.toLowerCase().includes('## test plan');
+const includesTestPlan = body_contains(
+  '## test plan',
+  'test plan:',
+  'tests:',
+  'test:',
+);
 if (!includesTestPlan && !isFromPhabricator) {
   // PRs from Phabricator never exports the Test Plan so let's disable this check.
   const title = ':clipboard: Missing Test Plan';