From 0d2e0abc45eb2295ff90352675b4a51e95ed6f42 Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Tue, 15 Jul 2025 04:13:15 -0700 Subject: [PATCH] Do not define default transformOrigin (#52598) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/52598 Defining this as {50%, 50%} mean we do unnecessary work as part of every transform. Instead set it to undefined, which means we'll ignore it when determining the final transform. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D78298587 fbshipit-source-id: 9d3b7375fc3bd9ea04f0a6d7e314fbba0fba6949 --- .../Components/View/__tests__/View-itest.js | 39 +++++++++++++++++++ .../renderer/components/view/BaseViewProps.h | 9 +---- .../react/renderer/graphics/Transform.h | 4 +- 3 files changed, 43 insertions(+), 9 deletions(-) diff --git a/packages/react-native/Libraries/Components/View/__tests__/View-itest.js b/packages/react-native/Libraries/Components/View/__tests__/View-itest.js index 8b48956b74e..77ff853ecb3 100644 --- a/packages/react-native/Libraries/Components/View/__tests__/View-itest.js +++ b/packages/react-native/Libraries/Components/View/__tests__/View-itest.js @@ -10,9 +10,14 @@ import '@react-native/fantom/src/setUpDefaultReactNativeEnvironment'; +import type {HostInstance} from 'react-native'; + +import ensureInstance from '../../../../src/private/__tests__/utilities/ensureInstance'; import * as Fantom from '@react-native/fantom'; import * as React from 'react'; +import {createRef} from 'react'; import {View} from 'react-native'; +import ReactNativeElement from 'react-native/src/private/webapis/dom/nodes/ReactNativeElement'; describe('', () => { describe('width and height style', () => { @@ -181,6 +186,40 @@ describe('', () => { , ); }); + + [ + [undefined, {x: -5, y: 0, width: 20, height: 10}], + ['50% 50%', {x: -5, y: 0, width: 20, height: 10}], + ['top left', {x: 0, y: 0, width: 20, height: 10}], + ['right bottom', {x: -10, y: 0, width: 20, height: 10}], + ].forEach(([transformOrigin, expectedBounds]) => { + it(`applies transformOrigin correctly for ${String(transformOrigin)}`, () => { + const root = Fantom.createRoot(); + + const viewRef = createRef(); + Fantom.runTask(() => { + root.render( + , + ); + }); + + const viewElement = ensureInstance(viewRef.current, ReactNativeElement); + + const viewBounds = viewElement.getBoundingClientRect(); + expect(viewBounds.x).toBe(expectedBounds.x); + expect(viewBounds.y).toBe(expectedBounds.y); + expect(viewBounds.width).toBe(expectedBounds.width); + expect(viewBounds.height).toBe(expectedBounds.height); + }); + }); }); describe('props', () => { diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/BaseViewProps.h b/packages/react-native/ReactCommon/react/renderer/components/view/BaseViewProps.h index f7e56418ef0..fe542284502 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/BaseViewProps.h +++ b/packages/react-native/ReactCommon/react/renderer/components/view/BaseViewProps.h @@ -84,14 +84,7 @@ class BaseViewProps : public YogaStylableProps, public AccessibilityProps { // Transform Transform transform{}; - TransformOrigin transformOrigin{ - { - ValueUnit{50.0f, UnitType::Percent}, - ValueUnit{50.0f, UnitType::Percent}, - }, - 0.0f, - - }; + TransformOrigin transformOrigin{}; BackfaceVisibility backfaceVisibility{}; bool shouldRasterize{}; std::optional zIndex{}; diff --git a/packages/react-native/ReactCommon/react/renderer/graphics/Transform.h b/packages/react-native/ReactCommon/react/renderer/graphics/Transform.h index 0e4e0e77af9..516d7d5cfbe 100644 --- a/packages/react-native/ReactCommon/react/renderer/graphics/Transform.h +++ b/packages/react-native/ReactCommon/react/renderer/graphics/Transform.h @@ -55,7 +55,9 @@ struct TransformOperation { }; struct TransformOrigin { - std::array xy; + std::array xy = { + ValueUnit(0.0f, UnitType::Undefined), + ValueUnit(0.0f, UnitType::Undefined)}; float z = 0.0f; bool operator==(const TransformOrigin& other) const {