Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't save matrix when using canvas.save

Browse Source 
Summary:
Canvas.save by default saves both the matrix (for translations,
scaling, etc) and the clip (clipRect) - in most of our cases, we really only
care to save and restore the clip, not the matrix.

Reviewed By: sriramramani

Differential Revision: D3235698
This commit is contained in:
Ahmed El-Helw
2016-04-28 10:44:32 -07:00
parent 118cc4b9b7
commit 0d21baf604
4 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/flat/AbstractClippingDrawCommand.java
+1 -3
View File
@@ -62,8 +62,6 @@ import android.graphics.Canvas;
// shows up during screenshot testing. Note that checking one side is enough, since if one side
// is infinite, all sides will be infinite, since we only set infinite for all sides at the
// same time - conversely, if one side is finite, all sides will be finite.
if (mNeedsClipping) {
canvas.clipRect(mClipLeft, mClipTop, mClipRight, mClipBottom);
}
canvas.clipRect(mClipLeft, mClipTop, mClipRight, mClipBottom);
}
}