From 0c0d24080fc535fe9fb016468d0ad9bcc615b405 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Mon, 26 May 2025 15:03:56 -0700 Subject: [PATCH] Make NativeAnimatedNodesManagerProvider not virtual (#51609) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/51609 changelog: [internal] NativeAnimatedNodesManagerProvider is not subclassed. Let's remove virtual methods and make it a final class. Reviewed By: lenaic Differential Revision: D75169108 fbshipit-source-id: 32121cf372ba94c8a7b86c61fd96efd75560f789 --- .../renderer/animated/NativeAnimatedNodesManagerProvider.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManagerProvider.h b/packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManagerProvider.h index 17d82a85c47..93e826ef00c 100644 --- a/packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManagerProvider.h +++ b/packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManagerProvider.h @@ -35,9 +35,7 @@ class NativeAnimatedNodesManagerProvider { NativeAnimatedNodesManager::StopOnRenderCallback stopOnRenderCallback = nullptr); - virtual ~NativeAnimatedNodesManagerProvider() = default; - - virtual std::shared_ptr getOrCreate( + std::shared_ptr getOrCreate( jsi::Runtime& runtime); std::shared_ptr get() { @@ -50,7 +48,7 @@ class NativeAnimatedNodesManagerProvider { std::shared_ptr getEventEmitterListener(); - protected: + private: std::shared_ptr nativeAnimatedNodesManager_; std::weak_ptr uiManagerBinding_;