From 0b48ef7ca8a463d8a61da409f0e71239a143d379 Mon Sep 17 00:00:00 2001 From: Andrei Shikov Date: Sun, 16 Jan 2022 23:06:11 -0800 Subject: [PATCH] Add more complex perf test for the mapbuffer Summary: Benchmarks performance/correctness of mapbuffer with several different types of data Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D33608299 fbshipit-source-id: 81b1e195aecac60ad1cc3ca416d1cf7b09feab32 --- ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.cpp | 2 +- ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.cpp b/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.cpp index eb1c155a1cd..5ebdf75e7f9 100644 --- a/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.cpp +++ b/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.cpp @@ -148,7 +148,7 @@ void MapBufferBuilder::putString(Key key, std::string const &value) { dynamicDataOffset_ += sizeOfDynamicData; } -void MapBufferBuilder::putMapBuffer(Key key, MapBuffer &map) { +void MapBufferBuilder::putMapBuffer(Key key, MapBuffer const &map) { int32_t mapBufferSize = map.getBufferSize(); // format [lenght of buffer (int)] + [bytes of MapBuffer] diff --git a/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.h b/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.h index f7190f7fd38..5e30a7e1330 100644 --- a/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.h +++ b/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.h @@ -84,7 +84,7 @@ class MapBufferBuilder { void putString(Key key, std::string const &value); - void putMapBuffer(Key key, MapBuffer &map); + void putMapBuffer(Key key, MapBuffer const &map); // TODO T83483191: This should return MapBuffer! MapBuffer build();