From 0b3d28f8f17f71fbe0b889ec430005d9e4f01db4 Mon Sep 17 00:00:00 2001 From: Luna Wei Date: Fri, 10 Sep 2021 11:40:50 -0700 Subject: [PATCH] Move multicolumn out to separate example Summary: Changelog: [Internal] Refactor FlatList examples, move multi-column under FlatList index Reviewed By: charlesbdudley Differential Revision: D30816719 fbshipit-source-id: 3fb9a30ddb58ca302a1b1b5a23ea964f3793b836 --- .../FlatList-multiColumn.js} | 18 +++++++----------- .../examples/FlatList/FlatListExampleIndex.js | 2 ++ .../rn-tester/js/utils/RNTesterList.android.js | 5 ----- .../rn-tester/js/utils/RNTesterList.ios.js | 5 ----- 4 files changed, 9 insertions(+), 21 deletions(-) rename packages/rn-tester/js/examples/{MultiColumn/MultiColumnExample.js => FlatList/FlatList-multiColumn.js} (94%) diff --git a/packages/rn-tester/js/examples/MultiColumn/MultiColumnExample.js b/packages/rn-tester/js/examples/FlatList/FlatList-multiColumn.js similarity index 94% rename from packages/rn-tester/js/examples/MultiColumn/MultiColumnExample.js rename to packages/rn-tester/js/examples/FlatList/FlatList-multiColumn.js index 7b8cc944d6e..fe53a7a628f 100644 --- a/packages/rn-tester/js/examples/MultiColumn/MultiColumnExample.js +++ b/packages/rn-tester/js/examples/FlatList/FlatList-multiColumn.js @@ -9,6 +9,7 @@ */ 'use strict'; +import type {RNTesterModuleExample} from '../../types/RNTesterTypes'; const RNTesterPage = require('../../components/RNTesterPage'); const React = require('react'); @@ -204,14 +205,9 @@ const styles = StyleSheet.create({ }, }); -exports.title = 'FlatList - MultiColumn'; -exports.category = 'ListView'; -exports.description = 'Performant, scrollable grid of data.'; -exports.examples = [ - { - title: 'Simple flat list multi column', - render: function(): React.Element { - return ; - }, - }, -]; +export default ({ + title: 'MultiColumn', + name: 'multicolumn', + description: 'Performant, scrollable grid of data', + render: () => , +}: RNTesterModuleExample); diff --git a/packages/rn-tester/js/examples/FlatList/FlatListExampleIndex.js b/packages/rn-tester/js/examples/FlatList/FlatListExampleIndex.js index a5ad439dbca..fb248930e37 100644 --- a/packages/rn-tester/js/examples/FlatList/FlatListExampleIndex.js +++ b/packages/rn-tester/js/examples/FlatList/FlatListExampleIndex.js @@ -15,6 +15,7 @@ import ContentInsetExample from './FlatList-contentInset'; import InvertedExample from './FlatList-inverted'; import onViewableItemsChangedExample from './FlatList-onViewableItemsChanged'; import WithSeparatorsExample from './FlatList-withSeparators'; +import MultiColumnExample from './FlatList-multiColumn'; export default ({ framework: 'React', @@ -30,5 +31,6 @@ export default ({ InvertedExample, onViewableItemsChangedExample, WithSeparatorsExample, + MultiColumnExample, ], }: RNTesterModule); diff --git a/packages/rn-tester/js/utils/RNTesterList.android.js b/packages/rn-tester/js/utils/RNTesterList.android.js index 012e1a9d151..18b9106ad92 100644 --- a/packages/rn-tester/js/utils/RNTesterList.android.js +++ b/packages/rn-tester/js/utils/RNTesterList.android.js @@ -47,11 +47,6 @@ const Components: Array = [ category: 'UI', module: require('../examples/Modal/ModalExample'), }, - { - key: 'MultiColumnExample', - category: 'ListView', - module: require('../examples/MultiColumn/MultiColumnExample'), - }, { key: 'NewAppScreenExample', module: require('../examples/NewAppScreen/NewAppScreenExample'), diff --git a/packages/rn-tester/js/utils/RNTesterList.ios.js b/packages/rn-tester/js/utils/RNTesterList.ios.js index 3a005005bab..633c964ae72 100644 --- a/packages/rn-tester/js/utils/RNTesterList.ios.js +++ b/packages/rn-tester/js/utils/RNTesterList.ios.js @@ -61,11 +61,6 @@ const Components: Array = [ module: require('../examples/Modal/ModalExample'), supportsTVOS: true, }, - { - key: 'MultiColumnExample', - module: require('../examples/MultiColumn/MultiColumnExample'), - supportsTVOS: true, - }, { key: 'NewAppScreenExample', module: require('../examples/NewAppScreen/NewAppScreenExample'),