mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Remove hermesV1Enabled Gradle property and simplify Hermes version resolution (#56733)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56733 - Remove `hermesV1Enabled` / `react.hermesV1Enabled` Gradle property and all branching it controls - Rename `HERMES_V1_VERSION_NAME` to `HERMES_VERSION_NAME` in `version.properties` - Remove `hermesV1Enabled` from `PrivateReactExtension`, `ProjectUtils`, `PropertyUtils`, `ReactPlugin` - Simplify `DependencyUtils.Coordinates` to single Hermes version - Make `-DHERMESVM_HEAP_HV_MODE=HEAP_HV_PREFER32` CMake flag unconditional - Remove `-DHERMES_V1_ENABLED=1` CMake argument from `ReactAndroid` and Fantom builds - Delete `hermesV1Enabled=true` from `gradle.properties` - Update all Gradle plugin tests ## Changelog: [Android][Removed] - Remove hermesV1Enabled and simplify the code ## Test plan - [x] Gradle plugin: `./gradlew -p packages/gradle-plugin build` — BUILD SUCCESSFUL, all tests pass - [x] Android: `./gradlew :packages:rn-tester:android:app:assembleDebug` — BUILD SUCCESSFUL Reviewed By: cortinico Differential Revision: D104244582 fbshipit-source-id: 7d12af5b934aac9d431e89d9a2eac41213c997a1
This commit is contained in:
1 parent
f9476256bd
commit
0a5c8c6b4b
20 files changed
+65
-382
No files matched your search
@@ -48,11 +48,9 @@ jobs:
|
||||
shell: bash
|
||||
run: |
|
||||
if [ "${{ inputs.use-hermes-nightly }}" == "true" ]; then
|
||||
# We are not publishing nightly versions of Hermes V1 yet.
|
||||
# For now, we can use the latest version of Hermes V1 published on maven and npm.
|
||||
HERMES_VERSION="latest-v1"
|
||||
else
|
||||
HERMES_VERSION=$(sed -n 's/^HERMES_V1_VERSION_NAME=//p' packages/react-native/sdks/hermes-engine/version.properties)
|
||||
HERMES_VERSION=$(sed -n 's/^HERMES_VERSION_NAME=//p' packages/react-native/sdks/hermes-engine/version.properties)
|
||||
fi
|
||||
echo "Using Hermes version: $HERMES_VERSION"
|
||||
echo "HERMES_VERSION=$HERMES_VERSION" >> $GITHUB_ENV
|
||||
|
||||
@@ -32,10 +32,9 @@ jobs:
|
||||
run: |
|
||||
echo "Setting hermes versions to latest"
|
||||
hermes_version=$(grep -oE 'HERMES_VERSION_NAME=([0-9]+\.[0-9]+\.[0-9]+)' packages/react-native/sdks/hermes-engine/version.properties | cut -d'=' -f2)
|
||||
hermes_v1_version=$(grep -oE 'HERMES_V1_VERSION_NAME=([0-9]+\.[0-9]+\.[0-9]+)' packages/react-native/sdks/hermes-engine/version.properties | cut -d'=' -f2)
|
||||
|
||||
echo "HERMES_VERSION=$hermes_version" >> $GITHUB_OUTPUT
|
||||
echo "HERMES_V1_VERSION=$hermes_v1_version" >> $GITHUB_OUTPUT
|
||||
echo "HERMES_V1_VERSION=$hermes_version" >> $GITHUB_OUTPUT
|
||||
- name: Print hermes versions
|
||||
run: |
|
||||
echo "HERMES_VERSION=${{ steps.set_hermes_versions.outputs.HERMES_VERSION }}"
|
||||
|
||||
Reference in new issue
Block a user