mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Fix a few readonly 10/n (#56948)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56948 ``` js1 flow-runner codemod flow/transformAllVariance --variance readonly --format-files=false ``` drop-conflicts landed-with-radar-review Reviewed By: SamChou19815 Differential Revision: D106144499 fbshipit-source-id: 85493334eae630d3dec7e5920633c076f8f09729
This commit is contained in:
1 parent
0676eb63a2
commit
09fc0432d1
193 files changed
+1473
-1312
No files matched your search
@@ -28,99 +28,104 @@ export type ReservedPrimitiveName =
|
||||
| 'DimensionPrimitive';
|
||||
|
||||
type CppTypeInfo = {
|
||||
+typeName: string,
|
||||
+localIncludes: ReadonlyArray<string>,
|
||||
+conversionIncludes: ReadonlyArray<string>,
|
||||
readonly typeName: string,
|
||||
readonly localIncludes: ReadonlyArray<string>,
|
||||
readonly conversionIncludes: ReadonlyArray<string>,
|
||||
};
|
||||
|
||||
type JavaImportInfo = {
|
||||
+interfaceImports: ReadonlyArray<string>,
|
||||
+delegateImports: ReadonlyArray<string>,
|
||||
readonly interfaceImports: ReadonlyArray<string>,
|
||||
readonly delegateImports: ReadonlyArray<string>,
|
||||
};
|
||||
|
||||
type ReservedTypeMapping = {
|
||||
+cpp: CppTypeInfo,
|
||||
+java: JavaImportInfo,
|
||||
readonly cpp: CppTypeInfo,
|
||||
readonly java: JavaImportInfo,
|
||||
};
|
||||
|
||||
const RESERVED_TYPES: {+[ReservedPrimitiveName]: ReservedTypeMapping} = {
|
||||
ColorPrimitive: {
|
||||
cpp: {
|
||||
typeName: 'SharedColor',
|
||||
localIncludes: ['#include <react/renderer/graphics/Color.h>'],
|
||||
conversionIncludes: [],
|
||||
const RESERVED_TYPES: {readonly [ReservedPrimitiveName]: ReservedTypeMapping} =
|
||||
{
|
||||
ColorPrimitive: {
|
||||
cpp: {
|
||||
typeName: 'SharedColor',
|
||||
localIncludes: ['#include <react/renderer/graphics/Color.h>'],
|
||||
conversionIncludes: [],
|
||||
},
|
||||
java: {
|
||||
interfaceImports: [],
|
||||
delegateImports: [
|
||||
'import com.facebook.react.bridge.ColorPropConverter;',
|
||||
],
|
||||
},
|
||||
},
|
||||
java: {
|
||||
interfaceImports: [],
|
||||
delegateImports: ['import com.facebook.react.bridge.ColorPropConverter;'],
|
||||
ImageSourcePrimitive: {
|
||||
cpp: {
|
||||
typeName: 'ImageSource',
|
||||
localIncludes: ['#include <react/renderer/imagemanager/primitives.h>'],
|
||||
conversionIncludes: [
|
||||
'#include <react/renderer/components/image/conversions.h>',
|
||||
],
|
||||
},
|
||||
java: {
|
||||
interfaceImports: ['import com.facebook.react.bridge.ReadableMap;'],
|
||||
delegateImports: ['import com.facebook.react.bridge.ReadableMap;'],
|
||||
},
|
||||
},
|
||||
},
|
||||
ImageSourcePrimitive: {
|
||||
cpp: {
|
||||
typeName: 'ImageSource',
|
||||
localIncludes: ['#include <react/renderer/imagemanager/primitives.h>'],
|
||||
conversionIncludes: [
|
||||
'#include <react/renderer/components/image/conversions.h>',
|
||||
],
|
||||
ImageRequestPrimitive: {
|
||||
cpp: {
|
||||
typeName: 'ImageRequest',
|
||||
localIncludes: [
|
||||
'#include <react/renderer/imagemanager/ImageRequest.h>',
|
||||
],
|
||||
conversionIncludes: [],
|
||||
},
|
||||
java: {
|
||||
// ImageRequestPrimitive is not used in Java component props
|
||||
interfaceImports: [],
|
||||
delegateImports: [],
|
||||
},
|
||||
},
|
||||
java: {
|
||||
interfaceImports: ['import com.facebook.react.bridge.ReadableMap;'],
|
||||
delegateImports: ['import com.facebook.react.bridge.ReadableMap;'],
|
||||
PointPrimitive: {
|
||||
cpp: {
|
||||
typeName: 'Point',
|
||||
localIncludes: ['#include <react/renderer/graphics/Point.h>'],
|
||||
conversionIncludes: [],
|
||||
},
|
||||
java: {
|
||||
interfaceImports: ['import com.facebook.react.bridge.ReadableMap;'],
|
||||
delegateImports: ['import com.facebook.react.bridge.ReadableMap;'],
|
||||
},
|
||||
},
|
||||
},
|
||||
ImageRequestPrimitive: {
|
||||
cpp: {
|
||||
typeName: 'ImageRequest',
|
||||
localIncludes: ['#include <react/renderer/imagemanager/ImageRequest.h>'],
|
||||
conversionIncludes: [],
|
||||
EdgeInsetsPrimitive: {
|
||||
cpp: {
|
||||
typeName: 'EdgeInsets',
|
||||
localIncludes: ['#include <react/renderer/graphics/RectangleEdges.h>'],
|
||||
conversionIncludes: [],
|
||||
},
|
||||
java: {
|
||||
interfaceImports: ['import com.facebook.react.bridge.ReadableMap;'],
|
||||
delegateImports: ['import com.facebook.react.bridge.ReadableMap;'],
|
||||
},
|
||||
},
|
||||
java: {
|
||||
// ImageRequestPrimitive is not used in Java component props
|
||||
interfaceImports: [],
|
||||
delegateImports: [],
|
||||
DimensionPrimitive: {
|
||||
cpp: {
|
||||
typeName: 'YGValue',
|
||||
localIncludes: [
|
||||
'#include <yoga/Yoga.h>',
|
||||
'#include <react/renderer/core/graphicsConversions.h>',
|
||||
],
|
||||
conversionIncludes: [
|
||||
'#include <react/renderer/components/view/conversions.h>',
|
||||
],
|
||||
},
|
||||
java: {
|
||||
interfaceImports: ['import com.facebook.yoga.YogaValue;'],
|
||||
delegateImports: [
|
||||
'import com.facebook.react.bridge.DimensionPropConverter;',
|
||||
],
|
||||
},
|
||||
},
|
||||
},
|
||||
PointPrimitive: {
|
||||
cpp: {
|
||||
typeName: 'Point',
|
||||
localIncludes: ['#include <react/renderer/graphics/Point.h>'],
|
||||
conversionIncludes: [],
|
||||
},
|
||||
java: {
|
||||
interfaceImports: ['import com.facebook.react.bridge.ReadableMap;'],
|
||||
delegateImports: ['import com.facebook.react.bridge.ReadableMap;'],
|
||||
},
|
||||
},
|
||||
EdgeInsetsPrimitive: {
|
||||
cpp: {
|
||||
typeName: 'EdgeInsets',
|
||||
localIncludes: ['#include <react/renderer/graphics/RectangleEdges.h>'],
|
||||
conversionIncludes: [],
|
||||
},
|
||||
java: {
|
||||
interfaceImports: ['import com.facebook.react.bridge.ReadableMap;'],
|
||||
delegateImports: ['import com.facebook.react.bridge.ReadableMap;'],
|
||||
},
|
||||
},
|
||||
DimensionPrimitive: {
|
||||
cpp: {
|
||||
typeName: 'YGValue',
|
||||
localIncludes: [
|
||||
'#include <yoga/Yoga.h>',
|
||||
'#include <react/renderer/core/graphicsConversions.h>',
|
||||
],
|
||||
conversionIncludes: [
|
||||
'#include <react/renderer/components/view/conversions.h>',
|
||||
],
|
||||
},
|
||||
java: {
|
||||
interfaceImports: ['import com.facebook.yoga.YogaValue;'],
|
||||
delegateImports: [
|
||||
'import com.facebook.react.bridge.DimensionPropConverter;',
|
||||
],
|
||||
},
|
||||
},
|
||||
};
|
||||
};
|
||||
|
||||
function getCppTypeForReservedPrimitive(name: ReservedPrimitiveName): string {
|
||||
return RESERVED_TYPES[name].cpp.typeName;
|
||||
|
||||
+5
-5
@@ -49,13 +49,13 @@ function getNativeTypeFromAnnotation(
|
||||
| ObjectTypeAnnotation<PropTypeAnnotation>
|
||||
| ReservedPropTypeAnnotation
|
||||
| {
|
||||
+default: string,
|
||||
+options: ReadonlyArray<string>,
|
||||
+type: 'StringEnumTypeAnnotation',
|
||||
readonly default: string,
|
||||
readonly options: ReadonlyArray<string>,
|
||||
readonly type: 'StringEnumTypeAnnotation',
|
||||
}
|
||||
| {
|
||||
+elementType: ObjectTypeAnnotation<PropTypeAnnotation>,
|
||||
+type: 'ArrayTypeAnnotation',
|
||||
readonly elementType: ObjectTypeAnnotation<PropTypeAnnotation>,
|
||||
readonly type: 'ArrayTypeAnnotation',
|
||||
},
|
||||
},
|
||||
nameParts: ReadonlyArray<string>,
|
||||
|
||||
+1
-1
@@ -128,7 +128,7 @@ class UnsupportedModulePropertyParserError extends ParserError {
|
||||
}
|
||||
|
||||
class UnsupportedTypeAnnotationParserError extends ParserError {
|
||||
+typeAnnotationType: string;
|
||||
readonly typeAnnotationType: string;
|
||||
constructor(
|
||||
nativeModuleName: string,
|
||||
typeAnnotation: $FlowFixMe,
|
||||
|
||||
Reference in new issue
Block a user