From 0851d5facbbea18e75c0a892d6b6a69a4d0bb49b Mon Sep 17 00:00:00 2001 From: Jonny Burger Date: Tue, 23 Apr 2019 03:29:40 -0700 Subject: [PATCH] Default textColor of #000000 on Android (#24540) Summary: By default, the text color is `#000000` on iOS and different on Android, e.g. `#808080`, depending on the manufactorer. This PR changes it so that newly created projects all have the text color `#000000` by default on both iOS and Android. The argument for this is to make the app by default be more consistent between platforms. Expo also does this: https://github.com/expo/expo/blob/master/android/expoview/src/main/res/values/styles.xml#L31 --- For context and for your consideration, I have started a discussion here with the topic of whether React Native should try to use OS defaults or be consistent between platforms: https://github.com/react-native-community/discussions-and-proposals/issues/121 [Android] [Changed] - New projects have a `#000000` by default. Pull Request resolved: https://github.com/facebook/react-native/pull/24540 Differential Revision: D15044898 Pulled By: cpojer fbshipit-source-id: 3197266504e1061ac7027bec3100e39e39a4406a --- RNTester/android/app/src/main/res/values/styles.xml | 1 + template/android/app/src/main/res/values/styles.xml | 1 + 2 files changed, 2 insertions(+) diff --git a/RNTester/android/app/src/main/res/values/styles.xml b/RNTester/android/app/src/main/res/values/styles.xml index 319eb0ca100..62fe59fa485 100644 --- a/RNTester/android/app/src/main/res/values/styles.xml +++ b/RNTester/android/app/src/main/res/values/styles.xml @@ -3,6 +3,7 @@ diff --git a/template/android/app/src/main/res/values/styles.xml b/template/android/app/src/main/res/values/styles.xml index 319eb0ca100..62fe59fa485 100644 --- a/template/android/app/src/main/res/values/styles.xml +++ b/template/android/app/src/main/res/values/styles.xml @@ -3,6 +3,7 @@