From 07073fbac832633bf1985ce199067aa7bf8a6035 Mon Sep 17 00:00:00 2001 From: Nick Lefever Date: Thu, 1 May 2025 05:48:52 -0700 Subject: [PATCH] Override `useShadowNodeStateOnClone` for OSS (#51041) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/51041 Enabling `useShadowNodeStateOnClone` by default on OSS to resolve https://github.com/facebook/react-native/issues/49694 Changelog: [Internal] Reviewed By: cortinico, cipolleschi Differential Revision: D73970421 fbshipit-source-id: 4021c9fc07a7fc28012c022f6131409486e8aea7 --- .../ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt | 2 ++ .../featureflags/ReactNativeFeatureFlagsOverridesOSSStable.h | 3 +++ 2 files changed, 5 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt index 04dd46b937d..50282190296 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android.kt @@ -19,4 +19,6 @@ public class ReactNativeFeatureFlagsOverrides_RNOSS_Stable_Android( override fun useTurboModules(): Boolean = bridgelessEnabled || turboModulesEnabled override fun updateRuntimeShadowNodeReferencesOnCommit(): Boolean = true + + override fun useShadowNodeStateOnClone(): Boolean = true } diff --git a/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSStable.h b/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSStable.h index d74fccb24c2..8f3e23de559 100644 --- a/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSStable.h +++ b/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsOverridesOSSStable.h @@ -29,5 +29,8 @@ class ReactNativeFeatureFlagsOverridesOSSStable bool updateRuntimeShadowNodeReferencesOnCommit() override { return true; } + bool useShadowNodeStateOnClone() override { + return true; + } }; } // namespace facebook::react