Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add Object type to schema

Browse Source 
Summary: This diff adds ObjectTypeAnnotation to the codegen schema, throwing for the missing implementation sites added in the next diffs for easier review-ability. Also adds a schema fixture that is flow checked for review, but does not export it because the tests would fail

Reviewed By: TheSavior

Differential Revision: D16759109

fbshipit-source-id: 75c93623e8c1ae2003c7cc638e8e3447f0e7aa38
This commit is contained in:
Rick Hanlon
2019-08-12 13:52:37 -07:00
committed by Facebook Github Bot
parent e6debfe1dd
commit 06259a7575
6 changed files with 146 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native-codegen/src/generators/components/GeneratePropsJavaInterface.js
Vendored
+3
View File
@@ -68,6 +68,9 @@ function getJavaValueForProp(prop: PropTypeShape, imports): string {
addNullable(imports);
return '@Nullable ReadableArray value';
}
case 'ObjectTypeAnnotation': {
throw new Error('Object type is not implemented');
}
case 'StringEnumTypeAnnotation':
addNullable(imports);
return '@Nullable String value';