From 05e2ec601b4414188ca1d5605b1fd1d794540f2f Mon Sep 17 00:00:00 2001 From: Jack Wang Date: Tue, 24 Mar 2020 15:30:12 -0700 Subject: [PATCH] Changing Order Of mOverrideColorScheme In Constructor Summary: Changelog: [Android] [Updated] mOverrideColorScheme should be assigned before the first colorSchemeForCurrentConfiguration call, so the initial setting of mColorScheme will reflect the override Reviewed By: zackargyle Differential Revision: D20630173 fbshipit-source-id: a2a2d174d3fc40c14f27dce6a7fa8e67203480c9 --- .../com/facebook/react/modules/appearance/AppearanceModule.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/appearance/AppearanceModule.java b/ReactAndroid/src/main/java/com/facebook/react/modules/appearance/AppearanceModule.java index b95ddfc871d..99b7c5311be 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/appearance/AppearanceModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/appearance/AppearanceModule.java @@ -47,8 +47,8 @@ public class AppearanceModule extends NativeAppearanceSpec { ReactApplicationContext reactContext, @Nullable OverrideColorScheme overrideColorScheme) { super(reactContext); - mColorScheme = colorSchemeForCurrentConfiguration(reactContext); mOverrideColorScheme = overrideColorScheme; + mColorScheme = colorSchemeForCurrentConfiguration(reactContext); } private String colorSchemeForCurrentConfiguration(Context context) {