From 05dec917f2e5f8288c0d9f31bc50c10bd0c0eab3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Oskar=20Kwas=CC=81niewski?= Date: Wed, 7 Aug 2024 07:56:19 -0700 Subject: [PATCH] fix: Hermes build for visionOS simulator (Release) (#45911) Summary: Building for the visionOS simulator in the Release scheme requires an x86_64 slice to be included. ![CleanShot 2024-08-06 at 15 18 29@2x](https://github.com/user-attachments/assets/6fd962eb-ab71-4937-affe-964d8fa39f53) ## Changelog: [IOS] [FIXED] - Include x86_64 slice when building for visionOS simulator Pull Request resolved: https://github.com/facebook/react-native/pull/45911 Test Plan: CI Green Reviewed By: GijsWeterings Differential Revision: D60828872 Pulled By: cipolleschi fbshipit-source-id: 74444ac0b6661baf427837d242ba0ca295da0d16 --- .../sdks/hermes-engine/utils/build-ios-framework.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-native/sdks/hermes-engine/utils/build-ios-framework.sh b/packages/react-native/sdks/hermes-engine/utils/build-ios-framework.sh index e44a1a1468b..89334593439 100755 --- a/packages/react-native/sdks/hermes-engine/utils/build-ios-framework.sh +++ b/packages/react-native/sdks/hermes-engine/utils/build-ios-framework.sh @@ -12,9 +12,9 @@ set -e # Given a specific target, retrieve the right architecture for it # $1 the target you want to build. Allowed values: iphoneos, iphonesimulator, catalyst, xros, xrsimulator function get_architecture { - if [[ $1 == "iphoneos" || $1 == "xros" || $1 == "xrsimulator" ]]; then + if [[ $1 == "iphoneos" || $1 == "xros" ]]; then echo "arm64" - elif [[ $1 == "iphonesimulator" ]]; then + elif [[ $1 == "iphonesimulator" || $1 == "xrsimulator" ]]; then echo "x86_64;arm64" elif [[ $1 == "catalyst" ]]; then echo "x86_64;arm64"