clean buck binary_jar warnings (#19769)

Summary:
This PR clears buck binary_jar warnings on CI.

CI is green https://circleci.com/gh/dulmandakh/react-native/458

Will see no binary_jar warnings on CI
Closes https://github.com/facebook/react-native/pull/19769

Reviewed By: mdvacca

Differential Revision: D8474558

Pulled By: hramos

fbshipit-source-id: a1e34a749218a6f87576475e49cbab52b0d3fafb

ReactAndroid/src/main/third-party/java/asm/BUCK

@@ -14,60 +14,60 @@ rn_android_library(
 
 rn_prebuilt_jar(
     name = "asm-core",
-    binary_jar = ":download-asm",
+    binary_jar = ":download-asm.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-asm",
+    name = "download-asm.jar",
     sha1 = "2fd56467a018aafe6ec6a73ccba520be4a7e1565",
     url = "mvn:org.ow2.asm:asm:jar:5.0.1",
 )
 
 rn_prebuilt_jar(
     name = "asm-commons",
-    binary_jar = ":download-asm-commons",
+    binary_jar = ":download-asm-commons.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-asm-commons",
+    name = "download-asm-commons.jar",
     sha1 = "7b7147a390a93a14d2edfdcf3f7b0e87a0939c3e",
     url = "mvn:org.ow2.asm:asm-commons:jar:5.0.1",
 )
 
 rn_prebuilt_jar(
     name = "asm-tree",
-    binary_jar = ":download-asm-tree",
+    binary_jar = ":download-asm-tree.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-asm-tree",
+    name = "download-asm-tree.jar",
     sha1 = "1b1e6e9d869acd704056d0a4223071a511c619e6",
     url = "mvn:org.ow2.asm:asm-tree:jar:5.0.1",
 )
 
 rn_prebuilt_jar(
     name = "asm-util",
-    binary_jar = ":download-asm-util",
+    binary_jar = ":download-asm-util.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-asm-util",
+    name = "download-asm-util.jar",
     sha1 = "7c8caddfbd0b2d7b844f8fcc75175b9cb9cf4724",
     url = "mvn:org.ow2.asm:asm-util:jar:5.0.1",
 )
 
 rn_prebuilt_jar(
     name = "asm-analysis",
-    binary_jar = ":download-asm-analysis",
+    binary_jar = ":download-asm-analysis.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-asm-analysis",
+    name = "download-asm-analysis.jar",
     sha1 = "e286fbee48efacb4e7c175f7948d9d8b2ab52352",
     url = "mvn:org.ow2.asm:asm-analysis:jar:5.0.1",
 )

ReactAndroid/src/main/third-party/java/fest/BUCK

@@ -11,24 +11,24 @@ rn_android_library(
 
 rn_prebuilt_jar(
     name = "fest-core",
-    binary_jar = ":fest-binary-jar",
+    binary_jar = ":fest-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "fest-binary-jar",
+    name = "fest-binary.jar",
     sha1 = "cb7c91cf614901928ae405f19d9bcdedf82781db",
     url = "mvn:org.easytesting:fest-assert-core:jar:2.0M10",
 )
 
 rn_prebuilt_jar(
     name = "fest-util",
-    binary_jar = ":fest-util-binary-jar",
+    binary_jar = ":fest-util-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "fest-util-binary-jar",
+    name = "fest-util-binary.jar",
     sha1 = "c4a8d7305b23b8d043be12c979813b096df11f44",
     url = "mvn:org.easytesting:fest-util:jar:1.2.5",
 )

ReactAndroid/src/main/third-party/java/javapoet/BUCK

@@ -1,11 +1,11 @@
 prebuilt_jar(
     name = "javapoet",
-    binary_jar = ":jsr305-binary-jar",
+    binary_jar = ":jsr305-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "jsr305-binary-jar",
+    name = "jsr305-binary.jar",
     sha1 = "ad3ba65c1788f4d814a4da056323e2b84412fb3c",
     url = "mvn:com.squareup:javapoet:jar:1.2.0",
 )

ReactAndroid/src/main/third-party/java/jsr-305/BUCK

@@ -1,11 +1,11 @@
 prebuilt_jar(
     name = "jsr-305",
-    binary_jar = ":jsr305-binary-jar",
+    binary_jar = ":jsr305-binary.jar",
     visibility = ["PUBLIC"],
 )
 
 remote_file(
-    name = "jsr305-binary-jar",
+    name = "jsr305-binary.jar",
     sha1 = "5871fb60dc68d67da54a663c3fd636a10a532948",
     url = "mvn:com.google.code.findbugs:jsr305:jar:3.0.0",
 )

ReactAndroid/src/main/third-party/java/jsr-330/BUCK

@@ -1,11 +1,11 @@
 prebuilt_jar(
     name = "jsr-330",
-    binary_jar = ":jsr330-binary-jar",
+    binary_jar = ":jsr330-binary.jar",
     visibility = ["PUBLIC"],
 )
 
 remote_file(
-    name = "jsr330-binary-jar",
+    name = "jsr330-binary.jar",
     sha1 = "6975da39a7040257bd51d21a231b76c915872d38",
     url = "mvn:javax.inject:javax.inject:jar:1",
 )

ReactAndroid/src/main/third-party/java/junit/BUCK

@@ -11,24 +11,24 @@ rn_android_library(
 
 rn_prebuilt_jar(
     name = "junit-core",
-    binary_jar = ":download-junit",
+    binary_jar = ":download-junit.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-junit",
+    name = "download-junit.jar",
     sha1 = "2973d150c0dc1fefe998f834810d68f278ea58ec",
     url = "mvn:junit:junit:jar:4.12",
 )
 
 rn_prebuilt_jar(
     name = "hamcrest",
-    binary_jar = ":download-hamcrest",
+    binary_jar = ":download-hamcrest.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-hamcrest",
+    name = "download-hamcrest.jar",
     sha1 = "63a21ebc981131004ad02e0434e799fd7f3a8d5a",
     url = "mvn:org.hamcrest:hamcrest-all:jar:1.3",
 )

ReactAndroid/src/main/third-party/java/mockito/BUCK

@@ -11,24 +11,24 @@ rn_android_library(
 
 rn_prebuilt_jar(
     name = "mockito-core",
-    binary_jar = ":mockito-binary-jar",
+    binary_jar = ":mockito-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "mockito-binary-jar",
+    name = "mockito-binary.jar",
     sha1 = "e8546f5bef4e061d8dd73895b4e8f40e3fe6effe",
     url = "mvn:org.mockito:mockito-core:jar:1.10.19",
 )
 
 rn_prebuilt_jar(
     name = "objenesis",
-    binary_jar = ":objenesis-binary-jar",
+    binary_jar = ":objenesis-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "objenesis-binary-jar",
+    name = "objenesis-binary.jar",
     sha1 = "87c0ea803b69252868d09308b4618f766f135a96",
     url = "mvn:org.objenesis:objenesis:jar:2.1",
 )

ReactAndroid/src/main/third-party/java/okhttp/BUCK

@@ -1,23 +1,23 @@
 prebuilt_jar(
     name = "okhttp3",
-    binary_jar = ":okhttp3-binary-jar",
+    binary_jar = ":okhttp3-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "okhttp3-binary-jar",
+    name = "okhttp3-binary.jar",
     sha1 = "7ef0f1d95bf4c0b3ba30bbae25e0e562b05cf75e",
     url = "mvn:com.squareup.okhttp3:okhttp:jar:3.10.0",
 )
 
 prebuilt_jar(
     name = "okhttp3-urlconnection",
-    binary_jar = ":okhttp3-urlconnection-binary-jar",
+    binary_jar = ":okhttp3-urlconnection-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "okhttp3-urlconnection-binary-jar",
+    name = "okhttp3-urlconnection-binary.jar",
     sha1 = "ec614c05825ddd2267677a99f585d3913474b125",
     url = "mvn:com.squareup.okhttp3:okhttp-urlconnection:jar:3.10.0",
 )

ReactAndroid/src/main/third-party/java/okio/BUCK

@@ -1,11 +1,11 @@
 prebuilt_jar(
     name = "okio",
-    binary_jar = ":okio-binary-jar",
+    binary_jar = ":okio-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "okio-binary-jar",
+    name = "okio-binary.jar",
     sha1 = "102d7be47241d781ef95f1581d414b0943053130",
     url = "mvn:com.squareup.okio:okio:jar:1.14.0",
 )

ReactAndroid/src/main/third-party/java/robolectric3/robolectric/BUCK

@@ -22,158 +22,158 @@ rn_android_library(
 
 rn_prebuilt_jar(
     name = "robolectric-core",
-    binary_jar = ":robolectric-binary-jar",
+    binary_jar = ":robolectric-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "robolectric-binary-jar",
+    name = "robolectric-binary.jar",
     sha1 = "f888cea3bc1a24110e315eb9827ab593610ea62f",
     url = "mvn:org.robolectric:robolectric:jar:3.0",
 )
 
 rn_prebuilt_jar(
     name = "robolectric-resources",
-    binary_jar = ":robolectric-resources-binary-jar",
+    binary_jar = ":robolectric-resources-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "robolectric-resources-binary-jar",
+    name = "robolectric-resources-binary.jar",
     sha1 = "1ab609054aab67cd13a434567467f4b4774f2465",
     url = "mvn:org.robolectric:robolectric-resources:jar:3.0",
 )
 
 rn_prebuilt_jar(
     name = "robolectric-annotations",
-    binary_jar = ":robolectric-annotations-binary-jar",
+    binary_jar = ":robolectric-annotations-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "robolectric-annotations-binary-jar",
+    name = "robolectric-annotations-binary.jar",
     sha1 = "2a6cfc072d7680694c1ff893c5dc8fec33163110",
     url = "mvn:org.robolectric:robolectric-annotations:jar:3.0",
 )
 
 rn_prebuilt_jar(
     name = "robolectric-utils",
-    binary_jar = ":robolectric-utils-binary-jar",
+    binary_jar = ":robolectric-utils-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "robolectric-utils-binary-jar",
+    name = "robolectric-utils-binary.jar",
     sha1 = "4bcecd8115fe7296088bb1636e6cbd7ae8927392",
     url = "mvn:org.robolectric:robolectric-utils:jar:3.0",
 )
 
 rn_prebuilt_jar(
     name = "bouncycastle",
-    binary_jar = ":bouncycastle-binary-jar",
+    binary_jar = ":bouncycastle-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "bouncycastle-binary-jar",
+    name = "bouncycastle-binary.jar",
     sha1 = "ce091790943599535cbb4de8ede84535b0c1260c",
     url = "mvn:org.bouncycastle:bcprov-jdk16:jar:1.46",
 )
 
 rn_prebuilt_jar(
     name = "vtd-xml",
-    binary_jar = ":vtd-xml-binary-jar",
+    binary_jar = ":vtd-xml-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "vtd-xml-binary-jar",
+    name = "vtd-xml-binary.jar",
     sha1 = "ee5bcf62c1acf76434ee9f1c67a840bafef72a6d",
     url = "mvn:com.ximpleware:vtd-xml:jar:2.11",
 )
 
 rn_prebuilt_jar(
     name = "icu",
-    binary_jar = ":icu-binary-jar",
+    binary_jar = ":icu-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "icu-binary-jar",
+    name = "icu-binary.jar",
     sha1 = "786d9055d4ca8c1aab4a7d4ac8283f973fd7e41f",
     url = "mvn:com.ibm.icu:icu4j:jar:53.1",
 )
 
 rn_prebuilt_jar(
     name = "android-all-4.1.2_r1-robolectric-0",  # name defines filename used by robolectric in runtime
-    binary_jar = ":robolectric-android-all-binary-jar",
+    binary_jar = ":robolectric-android-all-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 # This new rule will make the .jar file appear in the "right" location,
 # though that may change in the future
 export_file(
-    name = "robolectric-android-all-binary-jar",
-    src = ":robolectric-android-all-binary-remote-jar",
+    name = "robolectric-android-all-binary.jar",
+    src = ":robolectric-android-all-binary-remote.jar",
     out = "../android-all-4.1.2_r1-robolectric-0.jar",  # name defines filename used by robolectric in runtime
 )
 
 remote_file(
-    name = "robolectric-android-all-binary-remote-jar",
+    name = "robolectric-android-all-binary-remote.jar",
     sha1 = "aecc8ce5119a25fcea1cdf8285469c9d1261a352",
     url = "mvn:org.robolectric:android-all:jar:4.1.2_r1-robolectric-0",
 )
 
 rn_prebuilt_jar(
     name = "json-20080701",  # name defines filename used by robolectric in runtime
-    binary_jar = ":json-jar",
+    binary_jar = ":json.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 export_file(
-    name = "json-jar",
-    src = ":json-remote-jar",
+    name = "json.jar",
+    src = ":json-remote.jar",
     out = "../json-20080701.jar",  # name defines filename used by robolectric in runtime
 )
 
 remote_file(
-    name = "json-remote-jar",
+    name = "json-remote.jar",
     sha1 = "d652f102185530c93b66158b1859f35d45687258",
     url = "mvn:org.json:json:jar:20080701",
 )
 
 rn_prebuilt_jar(
     name = "tagsoup-1.2",  # name defines filename used by robolectric in runtime
-    binary_jar = ":tagsoup-jar",
+    binary_jar = ":tagsoup.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 export_file(
-    name = "tagsoup-jar",
-    src = ":tagsoup-remote-jar",
+    name = "tagsoup.jar",
+    src = ":tagsoup-remote.jar",
     out = "../tagsoup-1.2.jar",  # name defines filename used by robolectric in runtime
 )
 
 remote_file(
-    name = "tagsoup-remote-jar",
+    name = "tagsoup-remote.jar",
     sha1 = "639fd364750d7363c85797dc944b4a80f78fa684",
     url = "mvn:org.ccil.cowan.tagsoup:tagsoup:jar:1.2",
 )
 
 rn_prebuilt_jar(
     name = "shadows-core-3.0-16",  # name defines filename used by robolectric in runtime
-    binary_jar = ":robolectric-shadows-binary-jar",
+    binary_jar = ":robolectric-shadows-binary.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 export_file(
-    name = "robolectric-shadows-binary-jar",
-    src = ":robolectric-shadows-binary-remote-jar",
+    name = "robolectric-shadows-binary.jar",
+    src = ":robolectric-shadows-binary-remote.jar",
     out = "../shadows-core-3.0-16.jar",  # name defines filename used by robolectric in runtime
 )
 
 remote_file(
-    name = "robolectric-shadows-binary-remote-jar",
+    name = "robolectric-shadows-binary-remote.jar",
     sha1 = "39d7a856bf91640b1a6d044333336a2b3f3c198f",
     url = "https://repo1.maven.org/maven2/org/robolectric/shadows-core/3.0/shadows-core-3.0-16.jar",
 )

ReactAndroid/src/main/third-party/java/sqlite/BUCK

@@ -10,12 +10,12 @@ rn_android_library(
 
 rn_prebuilt_jar(
     name = "sqlite4java",
-    binary_jar = ":download-sqlite4java",
+    binary_jar = ":download-sqlite4java.jar",
     visibility = ["//ReactAndroid/..."],
 )
 
 remote_file(
-    name = "download-sqlite4java",
+    name = "download-sqlite4java.jar",
     sha1 = "745a7e2f35fdbe6336922e0d492c979dbbfa74fb",
     url = "mvn:com.almworks.sqlite4java:sqlite4java:jar:0.282",
 )