From 040d13960f2f91ad0992170e3afb4e04d11093d2 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Thu, 14 Sep 2023 23:45:17 -0700 Subject: [PATCH] Create empty constructor on ReactPackageTurboModuleManagerDelegate (#39461) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/39461 In this diff I'm creating an empty constructor on ReactPackageTurboModuleManagerDelegate. This will be used in the next diffs of the stack. I'm also resorting methods for better read of the class changelog: [intenral] internal Reviewed By: arushikesarwani94 Differential Revision: D49172554 fbshipit-source-id: 54073c86c87aa145b12e783d8d8f75cd1f5b228c --- ...eactPackageTurboModuleManagerDelegate.java | 28 +++++++++++-------- 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageTurboModuleManagerDelegate.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageTurboModuleManagerDelegate.java index fff2a356717..570f3b7312b 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageTurboModuleManagerDelegate.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/ReactPackageTurboModuleManagerDelegate.java @@ -42,18 +42,8 @@ public abstract class ReactPackageTurboModuleManagerDelegate extends TurboModule mShouldEnableLegacyModuleInterop && ReactFeatureFlags.unstable_useTurboModuleInteropForAllTurboModules; - @Override - public boolean unstable_shouldEnableLegacyModuleInterop() { - return mShouldEnableLegacyModuleInterop; - } - - @Override - public boolean unstable_shouldRouteTurboModulesThroughLegacyModuleInterop() { - return mShouldRouteTurboModulesThroughLegacyModuleInterop; - } - - private boolean shouldSupportLegacyPackages() { - return unstable_shouldEnableLegacyModuleInterop(); + protected ReactPackageTurboModuleManagerDelegate() { + super(); } protected ReactPackageTurboModuleManagerDelegate( @@ -142,6 +132,16 @@ public abstract class ReactPackageTurboModuleManagerDelegate extends TurboModule } } + @Override + public boolean unstable_shouldEnableLegacyModuleInterop() { + return mShouldEnableLegacyModuleInterop; + } + + @Override + public boolean unstable_shouldRouteTurboModulesThroughLegacyModuleInterop() { + return mShouldRouteTurboModulesThroughLegacyModuleInterop; + } + @Nullable @Override public TurboModule getModule(String moduleName) { @@ -253,6 +253,10 @@ public abstract class ReactPackageTurboModuleManagerDelegate extends TurboModule return moduleNames; } + private boolean shouldSupportLegacyPackages() { + return unstable_shouldEnableLegacyModuleInterop(); + } + public abstract static class Builder { private @Nullable List mPackages; private @Nullable ReactApplicationContext mContext;