Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix NVC for RCTTextInlineImage

Browse Source 
Summary:
This diff fixes the Static/Native ViewConfigs for RCTTextInlineImage.

Changelog: [Internal]

Reviewed By: p-sun, sshic

Differential Revision: D33674127

fbshipit-source-id: 8cf5ffeaca635b4afd30c437dc0f87ea1fdc15a8
This commit is contained in:
Ramanpreet Nara
2022-01-20 13:52:03 -08:00
committed by Facebook GitHub Bot
parent 26d05d8dd7
commit 0343e697fd
5 changed files with 31 additions and 80 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageShadowNode.java
+1 -1
View File
@@ -73,7 +73,7 @@ public class FrescoBasedReactTextInlineImageShadowNode extends ReactTextInlineIm
mHeaders = headers;
}
@ReactProp(name = "tintColor")
@ReactProp(name = "tintColor", customType = "Color")
public void setTintColor(int tintColor) {
mTintColor = tintColor;
}
ReactAndroid/src/main/java/com/facebook/react/views/text/frescosupport/FrescoBasedReactTextInlineImageViewManager.java
+2 -2
View File
@@ -12,8 +12,8 @@ import androidx.annotation.Nullable;
import com.facebook.drawee.backends.pipeline.Fresco;
import com.facebook.drawee.controller.AbstractDraweeControllerBuilder;
import com.facebook.react.module.annotations.ReactModule;
import com.facebook.react.uimanager.BaseViewManager;
import com.facebook.react.uimanager.ThemedReactContext;
import com.facebook.react.uimanager.ViewManager;
/**
* Manages Images embedded in Text nodes using Fresco. Since they are used only as a virtual nodes
@@ -21,7 +21,7 @@ import com.facebook.react.uimanager.ViewManager;
*/
@ReactModule(name = FrescoBasedReactTextInlineImageViewManager.REACT_CLASS)
public class FrescoBasedReactTextInlineImageViewManager
extends ViewManager<View, FrescoBasedReactTextInlineImageShadowNode> {
extends BaseViewManager<View, FrescoBasedReactTextInlineImageShadowNode> {
public static final String REACT_CLASS = "RCTTextInlineImage";