From 033ffcc14b8daf12f1dcc8a3bf072b9797e829e5 Mon Sep 17 00:00:00 2001 From: Vincent Riemer Date: Thu, 16 Jun 2022 13:05:54 -0700 Subject: [PATCH] Remove unecessary PointerEvent attributes Summary: Changelog: [iOS][Internal] Remove unecessary PointerEvent attributes Reviewed By: kacieb Differential Revision: D37115465 fbshipit-source-id: 079a297d1ce5b3d2c6766036a111c73bd75535f1 --- React/Fabric/RCTSurfaceTouchHandler.mm | 4 ---- .../react/renderer/components/view/PointerEvent.cpp | 2 -- .../react/renderer/components/view/PointerEvent.h | 10 ---------- .../renderer/components/view/TouchEventEmitter.cpp | 2 -- 4 files changed, 18 deletions(-) diff --git a/React/Fabric/RCTSurfaceTouchHandler.mm b/React/Fabric/RCTSurfaceTouchHandler.mm index 3be366ae13c..68bee422a62 100644 --- a/React/Fabric/RCTSurfaceTouchHandler.mm +++ b/React/Fabric/RCTSurfaceTouchHandler.mm @@ -180,8 +180,6 @@ static PointerEvent CreatePointerEventFromActiveTouch(ActiveTouch activeTouch) event.pressure = touch.force; event.pointerType = PointerTypeCStringFromUITouchType(activeTouch.touchType); event.clientPoint = touch.pagePoint; - event.target = touch.target; - event.timestamp = touch.timestamp; return event; } @@ -196,8 +194,6 @@ CreatePointerEventFromIncompleteHoverData(UIView *view, CGPoint clientLocation, event.pressure = 0.0; event.pointerType = "mouse"; event.clientPoint = RCTPointFromCGPoint(clientLocation); - event.target = (Tag)view.tag; - event.timestamp = timestamp; return event; } diff --git a/ReactCommon/react/renderer/components/view/PointerEvent.cpp b/ReactCommon/react/renderer/components/view/PointerEvent.cpp index 5b5e1128390..6e9ec3ed1d6 100644 --- a/ReactCommon/react/renderer/components/view/PointerEvent.cpp +++ b/ReactCommon/react/renderer/components/view/PointerEvent.cpp @@ -24,8 +24,6 @@ std::vector getDebugProps( {"pressure", getDebugDescription(pointerEvent.pressure, options)}, {"pointerType", getDebugDescription(pointerEvent.pointerType, options)}, {"clientPoint", getDebugDescription(pointerEvent.clientPoint, options)}, - {"target", getDebugDescription(pointerEvent.target, options)}, - {"timestamp", getDebugDescription(pointerEvent.timestamp, options)}, }; } diff --git a/ReactCommon/react/renderer/components/view/PointerEvent.h b/ReactCommon/react/renderer/components/view/PointerEvent.h index f9094b86696..a62e8ac530e 100644 --- a/ReactCommon/react/renderer/components/view/PointerEvent.h +++ b/ReactCommon/react/renderer/components/view/PointerEvent.h @@ -34,16 +34,6 @@ struct PointerEvent { * opposed to the coordinate within the page). */ Point clientPoint; - /* - * A reference to the view to which the event was originally dispatched. - */ - Tag target; - /* - * The time at which the event was created (in milliseconds). By - * specification, this value is time since epoch—but in reality, browsers' - * definitions vary. - */ - Float timestamp; }; #if RN_DEBUG_STRING_CONVERTIBLE diff --git a/ReactCommon/react/renderer/components/view/TouchEventEmitter.cpp b/ReactCommon/react/renderer/components/view/TouchEventEmitter.cpp index b9b7382c535..35ed17a1abb 100644 --- a/ReactCommon/react/renderer/components/view/TouchEventEmitter.cpp +++ b/ReactCommon/react/renderer/components/view/TouchEventEmitter.cpp @@ -68,8 +68,6 @@ static jsi::Value pointerEventPayload( object.setProperty(runtime, "pointerType", event.pointerType); object.setProperty(runtime, "clientX", event.clientPoint.x); object.setProperty(runtime, "clientY", event.clientPoint.y); - object.setProperty(runtime, "target", event.target); - object.setProperty(runtime, "timestamp", event.timestamp * 1000); return object; }