Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update type for tag in Android mounting layer

Browse Source 
Summary:
Easy replace of int -> Tag type in Binding

changelog: [internal]

Reviewed By: JoshuaGross

Differential Revision: D18429188

fbshipit-source-id: 08a19dff60bd90585f59a284be0e46ee7f381bcc
This commit is contained in:
David Vacca
2019-11-11 12:36:05 -08:00
committed by Facebook Github Bot
parent a62a685b14
commit 0284a73042
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp
+5 -5
View File
@@ -47,8 +47,8 @@ static constexpr auto UIManagerJavaDescriptor =
"com/facebook/react/fabric/FabricUIManager";
struct RemoveDeleteMetadata {
int tag;
int parentTag;
Tag tag;
Tag parentTag;
int index;
bool shouldRemove;
bool shouldDelete;
@@ -573,7 +573,7 @@ void Binding::schedulerDidFinishTransaction(
auto surfaceId = mountingTransaction->getSurfaceId();
auto &mutations = mountingTransaction->getMutations();
facebook::better::set<int> createAndDeleteTagsToProcess;
facebook::better::set<Tag> createAndDeleteTagsToProcess;
// When collapseDeleteCreateMountingInstructions_ is enabled, the
// createAndDeleteTagsToProcess set will contain all the tags belonging to
// CREATE and DELETE mutation instructions that needs to be processed. If a
@@ -589,7 +589,7 @@ void Binding::schedulerDidFinishTransaction(
} else if (mutation.type == ShadowViewMutation::Create) {
// TAG on 'Create' mutation instructions are part of the
// newChildShadowView
int tag = mutation.newChildShadowView.tag;
Tag tag = mutation.newChildShadowView.tag;
if (createAndDeleteTagsToProcess.find(tag) ==
createAndDeleteTagsToProcess.end()) {
createAndDeleteTagsToProcess.insert(tag);
@@ -627,7 +627,7 @@ void Binding::schedulerDidFinishTransaction(
// The TAG on 'Delete' mutation instructions are part of the
// oldChildShadowView. On the other side, the TAG on 'Create' mutation
// instructions are part of the newChildShadowView
int tag = mutationType == ShadowViewMutation::Create
Tag tag = mutationType == ShadowViewMutation::Create
? mutation.newChildShadowView.tag
: mutation.oldChildShadowView.tag;
if (createAndDeleteTagsToProcess.find(tag) ==