From 02578df4f731b411b7b0be5f5dd83bd7233d2800 Mon Sep 17 00:00:00 2001 From: Mike Grabowski Date: Sun, 24 Apr 2016 11:28:41 -0700 Subject: [PATCH] Fallback for textAlign: justify Summary:Fixes #5408 as per ide and vjeux suggestions here https://github.com/facebook/react-native/issues/529#issuecomment-107328799 Could've been probably done in a single `if` clause, but this is more explicit and leaves potential place for future implementation (if we ever decide to do so) Closes https://github.com/facebook/react-native/pull/7197 Differential Revision: D3217740 Pulled By: vjeux fb-gh-sync-id: aa08a5c42e43c1abe17b72a424ee96146f2667f6 fbshipit-source-id: aa08a5c42e43c1abe17b72a424ee96146f2667f6 --- Libraries/Text/TextStylePropTypes.js | 3 ++- .../com/facebook/react/views/text/ReactTextViewManager.java | 3 +++ .../facebook/react/views/textinput/ReactTextInputManager.java | 3 +++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/Libraries/Text/TextStylePropTypes.js b/Libraries/Text/TextStylePropTypes.js index 2f67fb73e8e..9ceea21dc25 100644 --- a/Libraries/Text/TextStylePropTypes.js +++ b/Libraries/Text/TextStylePropTypes.js @@ -41,7 +41,8 @@ var TextStylePropTypes = Object.assign(Object.create(ViewStylePropTypes), { letterSpacing: ReactPropTypes.number, lineHeight: ReactPropTypes.number, /** - * Specifies text alignment. The value 'justify' is only supported on iOS. + * Specifies text alignment. The value 'justify' is only supported on iOS and + * fallbacks to `left` on Android. */ textAlign: ReactPropTypes.oneOf( ['auto' /*default*/, 'left', 'right', 'center', 'justify'] diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextViewManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextViewManager.java index a1813a32afa..00595bb3a35 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextViewManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextViewManager.java @@ -65,6 +65,9 @@ public class ReactTextViewManager extends BaseViewManager