From 0199a0392c65fa72d9599262ba1b4f8e14c0fc04 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Wed, 13 May 2020 18:15:58 -0700 Subject: [PATCH] Revisit deprecated methods in UIManagerModule and update javadoc Summary: Ez diff that revisits deprecated methods in UIManagerModule and update javadoc Motivation: I'm cleaning up my fabric backlog before lockdown changelog: [Android] Update documentation of UIManagerModule methods Reviewed By: JoshuaGross Differential Revision: D21487609 fbshipit-source-id: 896ae21e02d5b1aa57b7158d714986fd1f8c9c5c --- .../facebook/react/uimanager/UIManagerModule.java | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java index 38ec86679cc..87d46f7a962 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java @@ -283,7 +283,8 @@ public class UIManagerModule extends ReactContextBaseJavaModule * Helper method to pre-compute the constants for a view manager. This method ensures that we * don't block for getting the constants for view managers during TTI * - * @param viewManagerNames + * @deprecated this method will not be available in FabricUIManager class. + * @param viewManagerNames {@link List} names of ViewManagers */ @Deprecated public void preComputeConstantsForViewManager(List viewManagerNames) { @@ -568,7 +569,7 @@ public class UIManagerModule extends ReactContextBaseJavaModule * This resolves to a simple {@link #manageChildren} call, but React doesn't have enough info in * JS to formulate it itself. * - * @deprecated This method will not be available in Fabric UIManager. + * @deprecated This method will not be available in Fabric UIManager class. */ @ReactMethod @Deprecated @@ -578,10 +579,10 @@ public class UIManagerModule extends ReactContextBaseJavaModule /** * Method which takes a container tag and then releases all subviews for that container upon - * receipt. TODO: The method name is incorrect and will be renamed, #6033872 + * receipt. * * @param containerTag the tag of the container for which the subviews must be removed - * @deprecated This method will not be available in Fabric UIManager. + * @deprecated This method will not be available in Fabric UIManager class. */ @ReactMethod @Deprecated @@ -631,7 +632,7 @@ public class UIManagerModule extends ReactContextBaseJavaModule * window which can cause unexpected results when measuring relative to things like ScrollViews * that can have offset content on the screen. * - * @deprecated This method will not be part of Fabric. + * @deprecated this method will not be available in FabricUIManager class. */ @ReactMethod @Deprecated @@ -664,7 +665,7 @@ public class UIManagerModule extends ReactContextBaseJavaModule /** * Check if the first shadow node is the descendant of the second shadow node * - * @deprecated This method will not be part of Fabric. + * @deprecated this method will not be available in FabricUIManager class. */ @ReactMethod @Deprecated