From 014a3b2d27d6c64772ad65b6d24f3a54afeb5e20 Mon Sep 17 00:00:00 2001 From: Arushi Kesarwani Date: Mon, 28 Aug 2023 17:46:27 -0700 Subject: [PATCH] Logging Bridgeless -> Runtime (#39154) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/39154 Changing the logs to have runtime mode instead of Bridgeless. changelog: [internal] internal allow-large-files Reviewed By: mdvacca Differential Revision: D48664389 fbshipit-source-id: a27e47b9b0fc08f8308ad177712cf68b0b1bce8f --- .../react-native/React/Base/RCTBridgeProxy.mm | 39 +++++++++---------- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/packages/react-native/React/Base/RCTBridgeProxy.mm b/packages/react-native/React/Base/RCTBridgeProxy.mm index 1c3a1a065c3..8b49d8d9e72 100644 --- a/packages/react-native/React/Base/RCTBridgeProxy.mm +++ b/packages/react-native/React/Base/RCTBridgeProxy.mm @@ -173,7 +173,7 @@ using namespace facebook; - (NSDictionary *)launchOptions { - [self logError:@"Bridgeless mode doesn't support launchOptions. Returning nil." cmd:_cmd]; + [self logError:@"This method is not supported. Returning nil." cmd:_cmd]; return nil; } @@ -191,7 +191,7 @@ using namespace facebook; - (RCTPerformanceLogger *)performanceLogger { - [self logWarning:@"Bridgeless mode does not support RCTPerformanceLogger. Returning nil." cmd:_cmd]; + [self logWarning:@"This method is not supported. Returning nil." cmd:_cmd]; return nil; } @@ -217,7 +217,7 @@ using namespace facebook; - (BOOL)isBatchActive { - [self logWarning:@"Bridgeless mode does not support batching. Returning NO." cmd:_cmd]; + [self logWarning:@"This method is not supported. Returning NO." cmd:_cmd]; return NO; } @@ -227,29 +227,29 @@ using namespace facebook; - (NSString *)bridgeDescription { - [self logWarning:@"Bridgeless mode does not support bridgeDescription. Returning \"BridgeProxy\"." cmd:_cmd]; + [self logWarning:@"This method is not supported. Returning \"BridgeProxy\"." cmd:_cmd]; return @"BridgeProxy"; } - (void)enqueueCallback:(NSNumber *)cbID args:(NSArray *)args { - [self logError:@"Bridgeless mode does not queuing callbacks by ids. No-oping." cmd:_cmd]; + [self logError:@"This method is not supported. No-oping." cmd:_cmd]; } - (RCTBridge *)batchedBridge { - [self logWarning:@"Bridgeless mode does not support batchedBridge. Returning bridge proxy." cmd:_cmd]; + [self logWarning:@"This method is not supported. Returning bridge proxy." cmd:_cmd]; return (RCTBridge *)self; } - (void)setBatchedBridge { - [self logError:@"Bridgeless mode does not support setBatchedBridge. No-oping." cmd:_cmd]; + [self logError:@"This method is not supported. No-oping." cmd:_cmd]; } - (RCTBridgeModuleListProvider)moduleProvider { - [self logWarning:@"Bridgeless mode does not support RCTBridgeModuleListProvider. Returning empty block" cmd:_cmd]; + [self logWarning:@"This method is not supported. Returning empty block" cmd:_cmd]; return ^{ return @[]; }; @@ -266,13 +266,13 @@ using namespace facebook; - (RCTBridge *)parentBridge { - [self logWarning:@"Bridgeless mode does not support parentBridge. Returning bridge proxy." cmd:_cmd]; + [self logWarning:@"This method is not supported. Returning bridge proxy." cmd:_cmd]; return (RCTBridge *)self; } - (BOOL)moduleSetupComplete { - [self logWarning:@"Bridgeless mode does not implement moduleSetupComplete. Returning YES." cmd:_cmd]; + [self logWarning:@"This method is not supported. Returning YES." cmd:_cmd]; return YES; } @@ -286,13 +286,12 @@ using namespace facebook; - (void)registerModuleForFrameUpdates:(id)module withModuleData:(RCTModuleData *)moduleData { - [self logError:@"Bridgeless mode does not allow custom modules to register themselves for frame updates. Nooping" - cmd:_cmd]; + [self logError:@"This method is not supported. Nooping" cmd:_cmd]; } - (RCTModuleData *)moduleDataForName:(NSString *)moduleName { - [self logError:@"Bridgeless mode does not use RCTModuleData. Returning nil." cmd:_cmd]; + [self logError:@"This method is not supported. Returning nil." cmd:_cmd]; return nil; } @@ -306,33 +305,33 @@ using namespace facebook; - (void)updateModuleWithInstance:(id)instance { - [self logError:@"Bridgeless mode does not support module replacement. Nooping." cmd:_cmd]; + [self logError:@"This method is not supported. Nooping." cmd:_cmd]; } - (void)startProfiling { - [self logWarning:@"Bridgeless mode does not support this method. Nooping." cmd:_cmd]; + [self logWarning:@"This method is not supported. Nooping." cmd:_cmd]; } - (void)stopProfiling:(void (^)(NSData *))callback { - [self logWarning:@"Bridgeless mode does not support this method. Nooping." cmd:_cmd]; + [self logWarning:@"This method is not supported. Nooping." cmd:_cmd]; } - (id)callNativeModule:(NSUInteger)moduleID method:(NSUInteger)methodID params:(NSArray *)params { - [self logError:@"Bridgeless mode does not support this method. Nooping and returning nil." cmd:_cmd]; + [self logError:@"This method is not supported. Nooping and returning nil." cmd:_cmd]; return nil; } - (void)logMessage:(NSString *)message level:(NSString *)level { - [self logWarning:@"Bridgeless mode does not support this method. Nooping." cmd:_cmd]; + [self logWarning:@"This method is not supported. Nooping." cmd:_cmd]; } - (void)_immediatelyCallTimer:(NSNumber *)timer { - [self logWarning:@"Bridgeless mode does not support this method. Nooping." cmd:_cmd]; + [self logWarning:@"This method is not supported. Nooping." cmd:_cmd]; } /** @@ -340,7 +339,7 @@ using namespace facebook; */ - (BOOL)inspectable { - [self logWarning:@"Bridgeless mode does not support this method. Returning NO." cmd:_cmd]; + [self logWarning:@"This method is not supported. Returning NO." cmd:_cmd]; return NO; }