From fef2ede9e808f44bf94f03b184419616c7a5e3af Mon Sep 17 00:00:00 2001 From: Christy Jacob Date: Wed, 19 Apr 2023 19:43:11 +0400 Subject: [PATCH] feat: review comments --- src/lib/elements/forms/inputSelect.svelte | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/lib/elements/forms/inputSelect.svelte b/src/lib/elements/forms/inputSelect.svelte index ac2a83f78..fd37a958c 100644 --- a/src/lib/elements/forms/inputSelect.svelte +++ b/src/lib/elements/forms/inputSelect.svelte @@ -31,13 +31,13 @@ return typeof value === 'boolean' ? true : !!value; }; - $: if (element && required) { - if (!isNotEmpty(value)) { - element.setCustomValidity('This field is required'); - } else { - element.setCustomValidity(''); - } - } else if (isNotEmpty(value)) { + $: if (required && !isNotEmpty(value)) { + element?.setCustomValidity('This field is required'); + } else { + element?.setCustomValidity(''); + } + + $: if (isNotEmpty(value)) { error = null; }