From eed2ccae27a3db43eee1b9b5a67befa0a8144867 Mon Sep 17 00:00:00 2001 From: Nikhil Date: Mon, 16 Oct 2023 11:01:09 +0530 Subject: [PATCH] Fix-6279-wrong-validation-of-projectid --- package-lock.json | 16 ++++++++-------- package.json | 2 +- src/lib/components/customId.svelte | 10 +++++----- src/lib/elements/forms/inputProjectId.svelte | 3 +-- tests/unit/elements/inputProjectId.test.ts | 2 +- 5 files changed, 16 insertions(+), 17 deletions(-) diff --git a/package-lock.json b/package-lock.json index adc0688bd..08b1daeab 100644 --- a/package-lock.json +++ b/package-lock.json @@ -43,7 +43,7 @@ "@typescript-eslint/eslint-plugin": "^6.5.0", "@typescript-eslint/parser": "^6.5.0", "@vitest/ui": "^0.29.7", - "eslint": "^8.48.0", + "eslint": "^8.51.0", "eslint-config-prettier": "^9.0.0", "eslint-plugin-svelte": "^2.33.0", "jsdom": "^22.1.0", @@ -1288,9 +1288,9 @@ } }, "node_modules/@eslint/js": { - "version": "8.50.0", - "resolved": "https://registry.npmjs.org/@eslint/js/-/js-8.50.0.tgz", - "integrity": "sha512-NCC3zz2+nvYd+Ckfh87rA47zfu2QsQpvc6k1yzTk+b9KzRj0wkGa8LSoGOXN6Zv4lRf/EIoZ80biDh9HOI+RNQ==", + "version": "8.51.0", + "resolved": "https://registry.npmjs.org/@eslint/js/-/js-8.51.0.tgz", + "integrity": "sha512-HxjQ8Qn+4SI3/AFv6sOrDB+g6PpUTDwSJiQqOrnneEk8L71161srI9gjzzZvYVbzHiVg/BvcH95+cK/zfIt4pg==", "dev": true, "engines": { "node": "^12.22.0 || ^14.17.0 || >=16.0.0" @@ -4159,15 +4159,15 @@ } }, "node_modules/eslint": { - "version": "8.50.0", - "resolved": "https://registry.npmjs.org/eslint/-/eslint-8.50.0.tgz", - "integrity": "sha512-FOnOGSuFuFLv/Sa+FDVRZl4GGVAAFFi8LecRsI5a1tMO5HIE8nCm4ivAlzt4dT3ol/PaaGC0rJEEXQmHJBGoOg==", + "version": "8.51.0", + "resolved": "https://registry.npmjs.org/eslint/-/eslint-8.51.0.tgz", + "integrity": "sha512-2WuxRZBrlwnXi+/vFSJyjMqrNjtJqiasMzehF0shoLaW7DzS3/9Yvrmq5JiT66+pNjiX4UBnLDiKHcWAr/OInA==", "dev": true, "dependencies": { "@eslint-community/eslint-utils": "^4.2.0", "@eslint-community/regexpp": "^4.6.1", "@eslint/eslintrc": "^2.1.2", - "@eslint/js": "8.50.0", + "@eslint/js": "8.51.0", "@humanwhocodes/config-array": "^0.11.11", "@humanwhocodes/module-importer": "^1.0.1", "@nodelib/fs.walk": "^1.2.8", diff --git a/package.json b/package.json index f98d98fd9..ab6aa73b7 100644 --- a/package.json +++ b/package.json @@ -55,7 +55,7 @@ "@typescript-eslint/eslint-plugin": "^6.5.0", "@typescript-eslint/parser": "^6.5.0", "@vitest/ui": "^0.29.7", - "eslint": "^8.48.0", + "eslint": "^8.51.0", "eslint-config-prettier": "^9.0.0", "eslint-plugin-svelte": "^2.33.0", "jsdom": "^22.1.0", diff --git a/src/lib/components/customId.svelte b/src/lib/components/customId.svelte index 913a1be8e..124868a77 100644 --- a/src/lib/components/customId.svelte +++ b/src/lib/components/customId.svelte @@ -2,7 +2,7 @@ import { trackEvent } from '$lib/actions/analytics'; import { InnerModal } from '$lib/components'; import { InputId } from '$lib/elements/forms'; - import {InputProjectId} from '$lib/elements/forms'; + import { InputProjectId } from '$lib/elements/forms'; export let show = false; export let name: string; export let id: string; @@ -30,10 +30,10 @@
{#if name === 'Project'} - - {:else} - - {/if} + + {:else} + + {/if}
diff --git a/src/lib/elements/forms/inputProjectId.svelte b/src/lib/elements/forms/inputProjectId.svelte index 5014f0589..80c35e8cb 100644 --- a/src/lib/elements/forms/inputProjectId.svelte +++ b/src/lib/elements/forms/inputProjectId.svelte @@ -54,7 +54,6 @@ class="u-cross-center u-line-height-1 u-color-text-gray" aria-hidden="true" /> - Allowed characters: lowercase alphanumeric and non-leading hyphen + Allowed characters: lowercase alphanumeric and non-leading hyphen - diff --git a/tests/unit/elements/inputProjectId.test.ts b/tests/unit/elements/inputProjectId.test.ts index 3af99b51e..b2cfcacf7 100644 --- a/tests/unit/elements/inputProjectId.test.ts +++ b/tests/unit/elements/inputProjectId.test.ts @@ -37,4 +37,4 @@ invalidStrings.forEach((invalidString) => { const input = getByPlaceholderText('Enter ID') as HTMLInputElement; expect(input.checkValidity()).toBe(false); }); -}); \ No newline at end of file +});