From e9d0a6fd0dab0910da0a077be5042285a95db5df Mon Sep 17 00:00:00 2001 From: harsh mahajan Date: Thu, 28 May 2026 12:30:13 +0530 Subject: [PATCH] fix: preserve boolean fields and deploymentRetention in git/domain flows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Extends the same fix to three non-settings flows that call functions.update or sites.update and had the same bugs: - functions/(modals)/createGit.svelte: enabled/logging || → ??; add deploymentRetention - functions/domains/add-domain/+page.svelte: enabled/logging || → ??; add providerSilentMode, providerRootDirectory, buildSpecification, and deploymentRetention which were missing entirely from this connect() call - sites/deployments/createGitDeploymentModal.svelte: enabled/logging/ providerSilentMode || → ??; add deploymentRetention --- .../function-[function]/(modals)/createGit.svelte | 7 ++++--- .../domains/add-domain/+page.svelte | 10 +++++++--- .../deployments/createGitDeploymentModal.svelte | 9 +++++---- 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/(modals)/createGit.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/(modals)/createGit.svelte index e9ee60e75..719ad3bf3 100644 --- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/(modals)/createGit.svelte +++ b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/(modals)/createGit.svelte @@ -83,8 +83,8 @@ events: $func.events || undefined, schedule: $func.schedule || undefined, timeout: $func.timeout || undefined, - enabled: $func.enabled || undefined, - logging: $func.logging || undefined, + enabled: $func.enabled ?? undefined, + logging: $func.logging ?? undefined, entrypoint: $func.entrypoint, commands: $func.commands || undefined, scopes: ($func.scopes as Scopes[]) || undefined, @@ -93,7 +93,8 @@ providerBranch: branch || undefined, providerSilentMode: $func.providerSilentMode ?? undefined, providerRootDirectory: $func.providerRootDirectory ?? undefined, - buildSpecification: $func.buildSpecification || undefined + buildSpecification: $func.buildSpecification || undefined, + deploymentRetention: $func.deploymentRetention ?? undefined }); } if (commit) { diff --git a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte index d5a79d397..bab19889c 100644 --- a/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte +++ b/src/routes/(console)/project-[region]-[project]/functions/function-[function]/domains/add-domain/+page.svelte @@ -141,14 +141,18 @@ events: data.func.events || undefined, schedule: data.func.schedule || undefined, timeout: data.func.timeout || undefined, - enabled: data.func.enabled || undefined, - logging: data.func.logging || undefined, + enabled: data.func.enabled ?? undefined, + logging: data.func.logging ?? undefined, entrypoint: data.func.entrypoint, commands: data.func.commands || undefined, scopes: (data.func.scopes as Scopes[]) || undefined, installationId: selectedInstallationId, providerRepositoryId: selectedRepository, - providerBranch: 'main' + providerBranch: 'main', + providerSilentMode: data.func.providerSilentMode ?? undefined, + providerRootDirectory: data.func.providerRootDirectory || undefined, + buildSpecification: data.func.buildSpecification || undefined, + deploymentRetention: data.func.deploymentRetention ?? undefined }); await invalidate(Dependencies.FUNCTION); } catch { diff --git a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/createGitDeploymentModal.svelte b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/createGitDeploymentModal.svelte index a96a73e6b..150b854ee 100644 --- a/src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/createGitDeploymentModal.svelte +++ b/src/routes/(console)/project-[region]-[project]/sites/site-[site]/deployments/createGitDeploymentModal.svelte @@ -85,8 +85,8 @@ siteId: site.$id, name: site.name, framework: site.framework as Framework, - enabled: site.enabled || undefined, - logging: site.logging || undefined, + enabled: site.enabled ?? undefined, + logging: site.logging ?? undefined, timeout: site.timeout || undefined, installCommand: site.installCommand || undefined, buildCommand: site.buildCommand || undefined, @@ -98,8 +98,9 @@ installationId: $installation.$id || undefined, providerRepositoryId: selectedRepository || undefined, providerBranch: branch || undefined, - providerSilentMode: site.providerSilentMode || undefined, - providerRootDirectory: site.providerRootDirectory || undefined + providerSilentMode: site.providerSilentMode ?? undefined, + providerRootDirectory: site.providerRootDirectory || undefined, + deploymentRetention: site.deploymentRetention ?? undefined }); } if (commit) {