From daf83bf4690aa26083fbbd34e43603af9439d40d Mon Sep 17 00:00:00 2001
From: Darshan <itznotabug@gmail.com>
Date: Sun, 19 Oct 2025 19:28:25 +0530
Subject: [PATCH] address comments from coderabbit.

---
 .../database-[database]/(suggestions)/empty.svelte       | 9 ++++++---
 .../databases/database-[database]/(suggestions)/store.ts | 2 +-
 .../database-[database]/table-[table]/+page.svelte       | 3 ++-
 3 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte
index 9cc05b304..9adb2b2d0 100644
--- a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte
+++ b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte
@@ -680,7 +680,7 @@
         if (!columnId) return;
 
         let columnIndex = -1;
-        let columnSchema: SuggestedColumnSchema;
+        let columnSchema: SuggestedColumnSchema = null;
 
         for (let index = 0; index < customColumns.length; index++) {
             if (customColumns[index].key === columnId) {
@@ -690,10 +690,13 @@
             }
         }
 
-        if (columnIndex !== -1) {
-            customColumns.splice(columnIndex, 1);
+        if (columnIndex === -1 || !columnSchema) {
+            return;
         }
 
+        // remove the column
+        customColumns.splice(columnIndex, 1);
+
         // store column with its index for undo
         columnBeingDeleted = { ...columnSchema, deletedIndex: columnIndex };
 
diff --git a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/store.ts b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/store.ts
index f05b5ca5d..a37d84a91 100644
--- a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/store.ts
+++ b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/store.ts
@@ -45,7 +45,7 @@ export const tableColumnSuggestions = writable<TableColumnSuggestions>({
     context: null,
     thinking: false,
     table: null,
-    force: false,
+    force: false
 });
 
 export const showIndexesSuggestions = writable<boolean>(false);
diff --git a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/+page.svelte b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/+page.svelte
index 1cce612e1..e440d2eb3 100644
--- a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/+page.svelte
+++ b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/table-[table]/+page.svelte
@@ -205,7 +205,7 @@
     </Container>
 
     <div class="databases-spreadsheet">
-        {#if hasColumns && hasValidColumns && !$tableColumnSuggestions.force}
+        {#if hasColumns && hasValidColumns && $tableColumnSuggestions.force !== true}
             {#if data.rows.total}
                 <Divider />
                 <SpreadSheet {data} bind:showRowCreateSheet={$showRowCreateSheet} />
@@ -266,6 +266,7 @@
                             $showCreateColumnSheet.show = true;
                         }} />
 
+                    <!-- TODO: gate for cloud only! need design -->
                     <EmptySheetCards
                         icon={IconAI}
                         title="Suggest columns"