From e0bfc2da8e2eb0f5cb6f61452fe5c05336efeb8e Mon Sep 17 00:00:00 2001 From: tglide <26071571+TGlide@users.noreply.github.com> Date: Fri, 14 Apr 2023 18:21:20 +0100 Subject: [PATCH 1/6] fix: non-expiring api key disallowing name updates --- .../console/project-[project]/overview/keys/[key]/+page.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/routes/console/project-[project]/overview/keys/[key]/+page.ts b/src/routes/console/project-[project]/overview/keys/[key]/+page.ts index 1c8f8a44d..e235ed2d6 100644 --- a/src/routes/console/project-[project]/overview/keys/[key]/+page.ts +++ b/src/routes/console/project-[project]/overview/keys/[key]/+page.ts @@ -10,6 +10,8 @@ export const load: PageLoad = async ({ params, depends }) => { const key = await sdk.forConsole.projects.getKey(params.project, params.key); if (key.expire) { key.expire = new Date(key.expire).toISOString().slice(0, 23); + } else { + key.expire = undefined; } return { From 8d855e53e3f6b4884877bd888ed82e55b7b8659e Mon Sep 17 00:00:00 2001 From: Christy Jacob Date: Mon, 17 Apr 2023 11:46:32 +0400 Subject: [PATCH 2/6] feat: update select validation for boolean attributes --- src/lib/elements/forms/inputSelect.svelte | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/src/lib/elements/forms/inputSelect.svelte b/src/lib/elements/forms/inputSelect.svelte index 0b3663529..85633d9f9 100644 --- a/src/lib/elements/forms/inputSelect.svelte +++ b/src/lib/elements/forms/inputSelect.svelte @@ -27,15 +27,28 @@ error = element.validationMessage; }; - $: if (element && required && !value) { + const isValid = (value: string | number | boolean) => { + if (typeof value === 'boolean') { + if (value === null || value === undefined) return false; + else return true; + } + + if (!value) { + return false; + } + + return true; + }; + + $: if (element && required && !isValid(value)) { element.setCustomValidity('This field is required'); } - $: if (element && required && value) { + $: if (element && required && isValid(value)) { element.setCustomValidity(''); } - $: if (value) { + $: if (isValid(value)) { error = null; } From 9a90fba3b00facc5ebf98521870fd782f495220a Mon Sep 17 00:00:00 2001 From: Christy Jacob Date: Mon, 17 Apr 2023 12:00:36 +0400 Subject: [PATCH 3/6] feat: update select validation for boolean attributes --- src/lib/elements/forms/inputSelect.svelte | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/lib/elements/forms/inputSelect.svelte b/src/lib/elements/forms/inputSelect.svelte index 85633d9f9..bbab9e44d 100644 --- a/src/lib/elements/forms/inputSelect.svelte +++ b/src/lib/elements/forms/inputSelect.svelte @@ -28,13 +28,14 @@ }; const isValid = (value: string | number | boolean) => { - if (typeof value === 'boolean') { - if (value === null || value === undefined) return false; - else return true; - } + if (value === null) return false; - if (!value) { - return false; + if (value === undefined) return false; + + if (typeof value !== 'boolean') { + if (!value) { + return false; + } } return true; From 1b9a9b64825a40d44d418a88ae158d26a6ea93b4 Mon Sep 17 00:00:00 2001 From: Christy Jacob Date: Tue, 18 Apr 2023 14:20:33 +0400 Subject: [PATCH 4/6] feat: review comments --- src/lib/elements/forms/inputSelect.svelte | 30 +++++++---------------- 1 file changed, 9 insertions(+), 21 deletions(-) diff --git a/src/lib/elements/forms/inputSelect.svelte b/src/lib/elements/forms/inputSelect.svelte index bbab9e44d..ac2a83f78 100644 --- a/src/lib/elements/forms/inputSelect.svelte +++ b/src/lib/elements/forms/inputSelect.svelte @@ -27,29 +27,17 @@ error = element.validationMessage; }; - const isValid = (value: string | number | boolean) => { - if (value === null) return false; - - if (value === undefined) return false; - - if (typeof value !== 'boolean') { - if (!value) { - return false; - } - } - - return true; + const isNotEmpty = (value: string | number | boolean) => { + return typeof value === 'boolean' ? true : !!value; }; - $: if (element && required && !isValid(value)) { - element.setCustomValidity('This field is required'); - } - - $: if (element && required && isValid(value)) { - element.setCustomValidity(''); - } - - $: if (isValid(value)) { + $: if (element && required) { + if (!isNotEmpty(value)) { + element.setCustomValidity('This field is required'); + } else { + element.setCustomValidity(''); + } + } else if (isNotEmpty(value)) { error = null; } From fef2ede9e808f44bf94f03b184419616c7a5e3af Mon Sep 17 00:00:00 2001 From: Christy Jacob Date: Wed, 19 Apr 2023 19:43:11 +0400 Subject: [PATCH 5/6] feat: review comments --- src/lib/elements/forms/inputSelect.svelte | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/lib/elements/forms/inputSelect.svelte b/src/lib/elements/forms/inputSelect.svelte index ac2a83f78..fd37a958c 100644 --- a/src/lib/elements/forms/inputSelect.svelte +++ b/src/lib/elements/forms/inputSelect.svelte @@ -31,13 +31,13 @@ return typeof value === 'boolean' ? true : !!value; }; - $: if (element && required) { - if (!isNotEmpty(value)) { - element.setCustomValidity('This field is required'); - } else { - element.setCustomValidity(''); - } - } else if (isNotEmpty(value)) { + $: if (required && !isNotEmpty(value)) { + element?.setCustomValidity('This field is required'); + } else { + element?.setCustomValidity(''); + } + + $: if (isNotEmpty(value)) { error = null; } From 532edeb3f69b1819c1d620364900c84f31a0568e Mon Sep 17 00:00:00 2001 From: "Vincent (Wen Yu) Ge" Date: Wed, 19 Apr 2023 22:23:26 +0000 Subject: [PATCH 6/6] Remove overly casual language from empty states --- src/lib/components/empty.svelte | 2 +- src/lib/components/permissions/team.svelte | 2 +- src/lib/components/permissions/user.svelte | 2 +- .../database-[database]/collection-[collection]/+page.svelte | 2 +- .../collection-[collection]/attributes/+page.svelte | 2 +- .../collection-[collection]/indexes/+page.svelte | 2 +- .../functions/function-[function]/executions/+page.svelte | 2 +- .../console/project-[project]/overview/platforms/+page.svelte | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/lib/components/empty.svelte b/src/lib/components/empty.svelte index ab7d091a4..2c01f69fa 100644 --- a/src/lib/components/empty.svelte +++ b/src/lib/components/empty.svelte @@ -42,7 +42,7 @@
Create your first {target} to get started.

- Need a hand? Check out our documentation. + Need a hand? Learn more in our documentation.

diff --git a/src/lib/components/permissions/team.svelte b/src/lib/components/permissions/team.svelte index 7b214f534..fdd4c5e9c 100644 --- a/src/lib/components/permissions/team.svelte +++ b/src/lib/components/permissions/team.svelte @@ -134,7 +134,7 @@ You have no teams. Create a team to see them here.

- Need a hand? Check out our diff --git a/src/lib/components/permissions/user.svelte b/src/lib/components/permissions/user.svelte index 4488d8f01..5835023b6 100644 --- a/src/lib/components/permissions/user.svelte +++ b/src/lib/components/permissions/user.svelte @@ -153,7 +153,7 @@ You have no users. Create a user to see them here.

- Need a hand? Check out our diff --git a/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/+page.svelte b/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/+page.svelte index 232e0be6d..d99f0bbf7 100644 --- a/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/+page.svelte +++ b/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/+page.svelte @@ -75,7 +75,7 @@

Create your first attribute to get started.

- Need a hand? Check out our documentation. + Need a hand? Learn more in our documentation.

diff --git a/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/attributes/+page.svelte b/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/attributes/+page.svelte index 68b72fb5c..10f82e672 100644 --- a/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/attributes/+page.svelte +++ b/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/attributes/+page.svelte @@ -180,7 +180,7 @@
Create your first attribute to get started.

- Need a hand? Check out our documentation. + Need a hand? Learn more in our documentation.

diff --git a/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/indexes/+page.svelte b/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/indexes/+page.svelte index 605450998..81cc43c89 100644 --- a/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/indexes/+page.svelte +++ b/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/indexes/+page.svelte @@ -125,7 +125,7 @@
Create your first attribute to get started.

- Need a hand? Check out our documentation. + Need a hand? Learn more in our documentation.

diff --git a/src/routes/console/project-[project]/functions/function-[function]/executions/+page.svelte b/src/routes/console/project-[project]/functions/function-[function]/executions/+page.svelte index fb36561ff..1e783436d 100644 --- a/src/routes/console/project-[project]/functions/function-[function]/executions/+page.svelte +++ b/src/routes/console/project-[project]/functions/function-[function]/executions/+page.svelte @@ -110,7 +110,7 @@

You have no execution logs. Create and activate a deployment to see it here.

-

Need a hand? Check out our documentation

+

Need a hand? Learn more in our documentation