From d2141c4df71eb41f8bfeb260a1c8e6f7562a7962 Mon Sep 17 00:00:00 2001
From: ernstmul <ernst.mulders@gmail.com>
Date: Wed, 9 Apr 2025 11:42:05 +0200
Subject: [PATCH] Fix: never allow no columns in filter

---
 src/routes/(console)/project-[project]/auth/+page.svelte      | 2 +-
 .../auth/user-[user]/identities/+page.svelte                  | 4 ++--
 .../project-[project]/auth/user-[user]/targets/+page.svelte   | 2 +-
 .../database-[database]/collection-[collection]/+page.svelte  | 2 +-
 src/routes/(console)/project-[project]/messaging/+page.svelte | 2 +-
 .../project-[project]/messaging/providers/+page.svelte        | 2 +-
 .../(console)/project-[project]/messaging/topics/+page.svelte | 2 +-
 .../messaging/topics/topic-[topic]/+page.svelte               | 4 ++--
 8 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/routes/(console)/project-[project]/auth/+page.svelte b/src/routes/(console)/project-[project]/auth/+page.svelte
index ec04ac85a..41ec7caac 100644
--- a/src/routes/(console)/project-[project]/auth/+page.svelte
+++ b/src/routes/(console)/project-[project]/auth/+page.svelte
@@ -59,7 +59,7 @@
             <SearchQuery search={data.search} placeholder="Search by name, email, phone, or ID" />
         </Layout.Stack>
         <Layout.Stack direction="row" alignItems="center" justifyContent="flex-end">
-            <ViewSelector view={View.Table} {columns} hideView allowNoColumns />
+            <ViewSelector view={View.Table} {columns} hideView />
             <Button on:mousedown={() => ($showCreateUser = true)} event="create_user" size="s">
                 <Icon size="s" icon={IconPlus} slot="start" />
                 <span class="text">Create user</span>
diff --git a/src/routes/(console)/project-[project]/auth/user-[user]/identities/+page.svelte b/src/routes/(console)/project-[project]/auth/user-[user]/identities/+page.svelte
index 4076b3698..901991a1d 100644
--- a/src/routes/(console)/project-[project]/auth/user-[user]/identities/+page.svelte
+++ b/src/routes/(console)/project-[project]/auth/user-[user]/identities/+page.svelte
@@ -48,13 +48,13 @@
             <div class="u-flex u-main-end u-gap-16 is-not-mobile">
                 <Filters query={data.query} {columns} />
                 <div>
-                    <ViewSelector view={View.Table} {columns} hideView allowNoColumns />
+                    <ViewSelector view={View.Table} {columns} hideView />
                 </div>
             </div>
         </div>
         <div class="u-flex u-gap-16 is-only-mobile u-margin-block-start-16">
             <div class="u-flex-basis-50-percent">
-                <ViewSelector view={View.Table} {columns} hideView allowNoColumns />
+                <ViewSelector view={View.Table} {columns} hideView />
             </div>
             <div class="u-flex-basis-50-percent">
                 <Filters query={data.query} {columns} fullWidthMobile />
diff --git a/src/routes/(console)/project-[project]/auth/user-[user]/targets/+page.svelte b/src/routes/(console)/project-[project]/auth/user-[user]/targets/+page.svelte
index 08494ee20..087596e67 100644
--- a/src/routes/(console)/project-[project]/auth/user-[user]/targets/+page.svelte
+++ b/src/routes/(console)/project-[project]/auth/user-[user]/targets/+page.svelte
@@ -34,7 +34,7 @@
 
             <div class="u-flex u-main-end u-gap-16 is-not-mobile">
                 <Filters query={data.query} {columns} />
-                <ViewSelector view={View.Table} {columns} hideView allowNoColumns />
+                <ViewSelector view={View.Table} {columns} hideView />
             </div>
         </div>
     </div>
diff --git a/src/routes/(console)/project-[project]/databases/database-[database]/collection-[collection]/+page.svelte b/src/routes/(console)/project-[project]/databases/database-[database]/collection-[collection]/+page.svelte
index 296078aef..160af2230 100644
--- a/src/routes/(console)/project-[project]/databases/database-[database]/collection-[collection]/+page.svelte
+++ b/src/routes/(console)/project-[project]/databases/database-[database]/collection-[collection]/+page.svelte
@@ -49,7 +49,7 @@
                 disabled={!(hasAttributes && hasValidAttributes)}
                 analyticsSource="database_documents" />
             <Layout.Stack direction="row" alignItems="center" justifyContent="flex-end">
-                <ViewSelector view={data.view} {columns} hideView allowNoColumns />
+                <ViewSelector view={data.view} {columns} hideView />
                 <Button
                     disabled={!(hasAttributes && hasValidAttributes)}
                     href={`${base}/project-${page.params.project}/databases/database-${page.params.database}/collection-${page.params.collection}/create`}
diff --git a/src/routes/(console)/project-[project]/messaging/+page.svelte b/src/routes/(console)/project-[project]/messaging/+page.svelte
index ccbe600de..a55584536 100644
--- a/src/routes/(console)/project-[project]/messaging/+page.svelte
+++ b/src/routes/(console)/project-[project]/messaging/+page.svelte
@@ -94,7 +94,7 @@
         </Layout.Stack>
         <Layout.Stack direction="row" alignItems="center" justifyContent="flex-end">
             <Filters query={data.query} {columns} analyticsSource="messaging_messages" />
-            <ViewSelector view={data.view} {columns} hideView allowNoColumns />
+            <ViewSelector view={data.view} {columns} hideView />
             {#if $canWriteMessages}
                 <CreateMessageDropdown />
             {/if}
diff --git a/src/routes/(console)/project-[project]/messaging/providers/+page.svelte b/src/routes/(console)/project-[project]/messaging/providers/+page.svelte
index 0ab4c0099..1521b23b7 100644
--- a/src/routes/(console)/project-[project]/messaging/providers/+page.svelte
+++ b/src/routes/(console)/project-[project]/messaging/providers/+page.svelte
@@ -30,7 +30,7 @@
         </Layout.Stack>
         <Layout.Stack direction="row" alignItems="center" justifyContent="flex-end">
             <Filters query={data.query} {columns} analyticsSource="messaging_providers" />
-            <ViewSelector view={View.Table} {columns} hideView allowNoColumns />
+            <ViewSelector view={View.Table} {columns} hideView />
             {#if $canWriteProviders}
                 <CreateProviderDropdown let:toggle>
                     <Button on:click={toggle} event="create_provider">
diff --git a/src/routes/(console)/project-[project]/messaging/topics/+page.svelte b/src/routes/(console)/project-[project]/messaging/topics/+page.svelte
index 6c3cdddc6..1318a583e 100644
--- a/src/routes/(console)/project-[project]/messaging/topics/+page.svelte
+++ b/src/routes/(console)/project-[project]/messaging/topics/+page.svelte
@@ -75,7 +75,7 @@
         </Layout.Stack>
         <Layout.Stack direction="row" alignItems="center" justifyContent="flex-end">
             <Filters query={data.query} {columns} analyticsSource="messaging_topics_filter" />
-            <ViewSelector view={View.Table} {columns} hideView allowNoColumns />
+            <ViewSelector view={View.Table} {columns} hideView />
             {#if $canWriteTopics}
                 <Button
                     on:click={() => {
diff --git a/src/routes/(console)/project-[project]/messaging/topics/topic-[topic]/+page.svelte b/src/routes/(console)/project-[project]/messaging/topics/topic-[topic]/+page.svelte
index a03180e6c..bb38c9723 100644
--- a/src/routes/(console)/project-[project]/messaging/topics/topic-[topic]/+page.svelte
+++ b/src/routes/(console)/project-[project]/messaging/topics/topic-[topic]/+page.svelte
@@ -108,7 +108,7 @@
             placeholder="Search by subscriber ID, target ID, user ID, or type">
             <div class="u-flex u-gap-16 is-not-mobile">
                 <Filters query={data.query} {columns} analyticsSource="messaging_topics" />
-                <ViewSelector view={View.Table} {columns} hideView allowNoColumns />
+                <ViewSelector view={View.Table} {columns} hideView />
                 <Button on:click={() => (showAdd = true)} event="create_subscriber">
                     <Icon icon={IconPlus} slot="start" size="s" />
                     Add subscriber
@@ -118,7 +118,7 @@
         <div class="u-flex u-gap-16 is-only-mobile u-margin-block-start-16">
             <div class="u-flex-basis-50-percent">
                 <!-- TODO: fix width -->
-                <ViewSelector view={View.Table} {columns} hideView allowNoColumns />
+                <ViewSelector view={View.Table} {columns} hideView />
             </div>
             <div class="u-flex-basis-50-percent">
                 <!-- TODO: fix width -->