From cc193c4d3c1fa81b6b54a690a186708d7cf26a63 Mon Sep 17 00:00:00 2001 From: Darshan Date: Thu, 23 Oct 2025 16:33:28 +0530 Subject: [PATCH] fix: mobile logic. fix: overlay on mobile's side sheet. --- .../(suggestions)/empty.svelte | 33 +++++++++++++++---- .../(suggestions)/options.svelte | 10 +++++- 2 files changed, 35 insertions(+), 8 deletions(-) diff --git a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte index fd097e7ac..69d3e5175 100644 --- a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte +++ b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/empty.svelte @@ -56,6 +56,7 @@ let headerElement: HTMLElement | null = null; let rangeOverlayEl: HTMLDivElement | null = null; let fadeBottomOverlayEl: HTMLDivElement | null = null; + let snowFadeBottomOverlayEl: HTMLDivElement | null = null; let customColumns = $state< (SuggestedColumnSchema & { elements?: []; isPlaceholder?: boolean })[] @@ -70,6 +71,8 @@ let previousColumnId = $state(null); let selectedColumnName = $state(null); + let triggerColumnId = $state(null); + // for deleting a column + undo let undoTimer: ReturnType | null = $state(null); let columnBeingDeleted: (SuggestedColumnSchema & { deletedIndex?: number }) | null = @@ -535,7 +538,7 @@ async function updateOverlaysForMobile(value: boolean) { if ($isSmallViewport) { setTimeout(() => { - [rangeOverlayEl, fadeBottomOverlayEl].forEach((el) => { + [rangeOverlayEl, fadeBottomOverlayEl, snowFadeBottomOverlayEl].forEach((el) => { if (el) { el.style.opacity = value ? '0' : '1'; } @@ -1097,7 +1100,15 @@ + onShowStateChanged={onPopoverShowStateChanged} + triggerOpen={() => { + if (triggerColumnId === column.id) { + triggerColumnId = null; + return true; + } + + return false; + }}> {#snippet children(toggle)} { - if (isColumnInteractable && !$isTabletViewport) { - selectColumnWithId(column); + if (isColumnInteractable) { + if (!$isTabletViewport) { + selectColumnWithId(column); + } else if ($isSmallViewport) { + triggerColumnId = column.id; + } } }}> @@ -1264,7 +1279,11 @@ data-collapsed-tabs={!$expandTabs}> -
+
+
{#if $tableColumnSuggestions.thinking}
@@ -1381,8 +1400,8 @@ {creatingColumns ? 'Creating columns' : $isSmallViewport - ? 'Review and edit suggested columns' - : 'Review and edit suggested columns before applying'} + ? 'Click headers or cells to edit columns' + : 'Click headers or cells to edit columns before applying'} diff --git a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/options.svelte b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/options.svelte index b7d964513..113415ecf 100644 --- a/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/options.svelte +++ b/src/routes/(console)/project-[region]-[project]/databases/database-[database]/(suggestions)/options.svelte @@ -11,7 +11,8 @@ toggleOnTapClick = true, onShowStateChanged = null, enabled = true, - onChildrenClick + onChildrenClick, + triggerOpen }: { children: Snippet<[toggle: (event: Event) => void]>; tooltipChildren: Snippet<[toggle: (event: Event) => void]>; @@ -20,6 +21,7 @@ onShowStateChanged?: (showing: boolean) => void; enabled?: boolean; onChildrenClick?: () => void; + triggerOpen?: () => boolean; } = $props(); let showSheet = $state(false); @@ -29,6 +31,12 @@ showSheet = false; } }); + + $effect(() => { + if ($isSmallViewport && triggerOpen && triggerOpen()) { + showSheet = true; + } + });