From cb4e54217afce22e9874fbb5e0a683f7ca105d8e Mon Sep 17 00:00:00 2001 From: Arman Date: Wed, 16 Aug 2023 17:17:28 +0200 Subject: [PATCH] fix: code review --- src/lib/layout/logs.svelte | 25 +++++++------------------ 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/src/lib/layout/logs.svelte b/src/lib/layout/logs.svelte index e7d5e3781..2f1607cf8 100644 --- a/src/lib/layout/logs.svelte +++ b/src/lib/layout/logs.svelte @@ -10,7 +10,6 @@ TableCellHead, TableCellText, TableHeader, - TableList, TableRow } from '$lib/elements/table'; import { beforeNavigate } from '$app/navigation'; @@ -27,21 +26,18 @@ } beforeNavigate((n) => { - if ($log.show) { - if (n.type === 'popstate') { - n.cancel(); - } - $log.show = false; + if (!$log.show) return; + if (n.type === 'popstate') { + n.cancel(); } + $log.show = false; }); $: execution = $log.data; $: func = $log.func; - $: if (execution) { - if (execution.errors) { - selectedResponse = 'errors'; - } + $: if (execution?.errors) { + selectedResponse = 'errors'; } @@ -85,20 +81,13 @@ {calculateTime(execution.duration)} - +
  • Created at:
  • -
    {execution.status}