From ca17d04269bbe1c1b01cd937543f44eeef837350 Mon Sep 17 00:00:00 2001 From: Torsten Dittmann Date: Thu, 23 Mar 2023 16:33:56 +0100 Subject: [PATCH] Apply suggestions from code review --- src/routes/console/project-[project]/+error.svelte | 4 +--- .../project-[project]/auth/usage/[[period]]/+page.ts | 4 +--- .../project-[project]/databases/usage/[[period]]/+page.ts | 4 +--- .../function-[function]/usage/[[period]]/+page.ts | 7 ++----- .../project-[project]/storage/usage/[[period]]/+page.ts | 7 ++----- 5 files changed, 7 insertions(+), 19 deletions(-) diff --git a/src/routes/console/project-[project]/+error.svelte b/src/routes/console/project-[project]/+error.svelte index a2297503a..0b310cfd5 100644 --- a/src/routes/console/project-[project]/+error.svelte +++ b/src/routes/console/project-[project]/+error.svelte @@ -7,7 +7,5 @@ {$page.status} -
-

{$page.error.message}

-
+

{$page.error.message}

diff --git a/src/routes/console/project-[project]/auth/usage/[[period]]/+page.ts b/src/routes/console/project-[project]/auth/usage/[[period]]/+page.ts index 08fc0fd6e..b922f44f6 100644 --- a/src/routes/console/project-[project]/auth/usage/[[period]]/+page.ts +++ b/src/routes/console/project-[project]/auth/usage/[[period]]/+page.ts @@ -15,8 +15,6 @@ export const load: PageLoad = async ({ params }) => { deleted: response.usersDelete as unknown as Models.Metric[] }; } catch (err) { - throw error(err.code, { - message: err.message - }) + throw error(err.code, err.message); } }; diff --git a/src/routes/console/project-[project]/databases/usage/[[period]]/+page.ts b/src/routes/console/project-[project]/databases/usage/[[period]]/+page.ts index d2e344000..b439881ff 100644 --- a/src/routes/console/project-[project]/databases/usage/[[period]]/+page.ts +++ b/src/routes/console/project-[project]/databases/usage/[[period]]/+page.ts @@ -15,8 +15,6 @@ export const load: PageLoad = async ({ params }) => { deleted: response.databasesDelete as unknown as Models.Metric[] }; } catch (err) { - throw error(err.code, { - message: err.message - }) + throw error(err.code, err.message); } }; diff --git a/src/routes/console/project-[project]/functions/function-[function]/usage/[[period]]/+page.ts b/src/routes/console/project-[project]/functions/function-[function]/usage/[[period]]/+page.ts index 16799c7e6..e1cd0ea88 100644 --- a/src/routes/console/project-[project]/functions/function-[function]/usage/[[period]]/+page.ts +++ b/src/routes/console/project-[project]/functions/function-[function]/usage/[[period]]/+page.ts @@ -3,8 +3,7 @@ import { sdk } from '$lib/stores/sdk'; import type { PageLoad } from './$types'; import { error } from '@sveltejs/kit'; -export const load: PageLoad = async ({ params, parent }) => { - await parent(); +export const load: PageLoad = async ({ params }) => { try { const response = await sdkForProject.functions.getFunctionUsage( params.function, @@ -16,8 +15,6 @@ export const load: PageLoad = async ({ params, parent }) => { errors: response.buildsFailure as unknown as Models.Metric[] }; } catch (err) { - throw error(err.code, { - message: err.message - }) + throw error(err.code, err.message); } }; diff --git a/src/routes/console/project-[project]/storage/usage/[[period]]/+page.ts b/src/routes/console/project-[project]/storage/usage/[[period]]/+page.ts index 642886057..18c05a43f 100644 --- a/src/routes/console/project-[project]/storage/usage/[[period]]/+page.ts +++ b/src/routes/console/project-[project]/storage/usage/[[period]]/+page.ts @@ -3,8 +3,7 @@ import { sdk } from '$lib/stores/sdk'; import type { PageLoad } from './$types'; import { error } from '@sveltejs/kit'; -export const load: PageLoad = async ({ params, parent }) => { - await parent(); +export const load: PageLoad = async ({ params }) => { try { const response = await sdkForProject.storage.getUsage(params.period ?? '30d'); @@ -16,8 +15,6 @@ export const load: PageLoad = async ({ params, parent }) => { deleted: response.bucketsDelete as unknown as Models.Metric[] }; } catch (err) { - throw error(err.code, { - message: err.message - }) + throw error(err.code, err.message); } };