From bf14907540e44ab69e84e80b8f5d892f9dbdb606 Mon Sep 17 00:00:00 2001
From: tglide <26071571+TGlide@users.noreply.github.com>
Date: Mon, 23 Jan 2023 17:00:54 +0000
Subject: [PATCH] refactor: pr reviews

---
 src/lib/components/copy.svelte       |  2 +-
 src/lib/components/eventModal.svelte | 12 ++++++------
 tsconfig.json                        |  2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/lib/components/copy.svelte b/src/lib/components/copy.svelte
index 7fd1cb18b..f1690ce8c 100644
--- a/src/lib/components/copy.svelte
+++ b/src/lib/components/copy.svelte
@@ -6,7 +6,7 @@
 
     export let value: string;
     export let event: string = null;
-    export let appendTo: any | undefined = undefined;
+    export let appendTo: Parameters<typeof tooltip>['1']['appendTo'] = undefined;
 
     let content = 'Click to copy';
 
diff --git a/src/lib/components/eventModal.svelte b/src/lib/components/eventModal.svelte
index 9aadc6828..09d07e93c 100644
--- a/src/lib/components/eventModal.svelte
+++ b/src/lib/components/eventModal.svelte
@@ -54,7 +54,7 @@
         if (typeof value === 'string') {
             selected[field as 'attribute'] = selected[field] === value ? null : value;
         } else {
-            selected[field as any] = (selected[field] as any)?.name === value.name ? null : value;
+            selected[field] = selected[field]?.name === value.name ? null : value;
         }
 
         customInput = null;
@@ -121,8 +121,8 @@
         }
     }
 
-    function toggleShowInput(e?: Event) {
-        e?.preventDefault();
+    function toggleShowInput(e: Event) {
+        e.preventDefault();
 
         showInput = !showInput;
         if (showInput) return;
@@ -326,7 +326,7 @@
         </div>
     {:else}
         <div class="input-text-wrapper" style="--amount-of-buttons:2" bind:this={copyParent}>
-            <div type="text" readonly style="min-height: 2.5rem;">
+            <div style="min-height: 2.5rem;">
                 {#each eventString as route, i}
                     <span
                         class:u-opacity-0-5={helper !== route.description}
@@ -342,9 +342,9 @@
             <div class="options-list">
                 {#key copyParent}
                     <button
-                        on:click|preventDefault={() => {
+                        on:click={(e) => {
                             customInput = inputValue;
-                            toggleShowInput();
+                            toggleShowInput(e);
                         }}
                         use:tooltip={{ content: 'Edit event', appendTo: copyParent }}
                         class="options-list-button"
diff --git a/tsconfig.json b/tsconfig.json
index d164d251e..5987c9cb1 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -1,7 +1,7 @@
 {
     "extends": "./.svelte-kit/tsconfig.json",
     "compilerOptions": {
-        "lib": ["webworker"],
+        "lib": ["webworker", "ES2016", "DOM"],
         "module": "ESNext",
         "moduleResolution": "Node",
         "importsNotUsedAsValues": "error",