From b89485ba20e2cd9268fba88cacd0c253c6ef0974 Mon Sep 17 00:00:00 2001
From: Arman <arman@appwrite.io>
Date: Thu, 31 Aug 2023 14:16:07 +0200
Subject: [PATCH] chore: fix warnings

---
 package-lock.json                             | 48 +++++++++----------
 package.json                                  |  8 ++--
 src/lib/components/feedback/evaluation.svelte |  7 ++-
 .../components/feedback/feedbackNPS.svelte    |  2 +
 src/lib/elements/forms/inputFile.svelte       |  1 +
 .../elements/forms/inputSelectSearch.svelte   |  2 +
 src/lib/elements/forms/inputTextarea.svelte   |  2 +-
 src/lib/elements/table/cellCheck.svelte       |  7 ++-
 src/lib/stores/feedback.ts                    |  5 +-
 .../attributes/relationship.svelte            |  2 +-
 .../attributes/relationship.svelte            |  8 ++--
 11 files changed, 51 insertions(+), 41 deletions(-)

diff --git a/package-lock.json b/package-lock.json
index c750d3862..3a6a4f027 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -52,11 +52,11 @@
                 "prettier-plugin-svelte": "^3.0.3",
                 "sass": "^1.59.3",
                 "svelte": "^4.2.0",
-                "svelte-check": "^3.4.3",
+                "svelte-check": "^3.5.1",
                 "svelte-jester": "^2.3.2",
-                "svelte-preprocess": "^5.0.3",
-                "tslib": "^2.5.0",
-                "typescript": "^5.0.2",
+                "svelte-preprocess": "^5.0.4",
+                "tslib": "^2.6.2",
+                "typescript": "^5.2.2",
                 "vite": "^4.4.9",
                 "vitest": "^0.29.7"
             },
@@ -8204,9 +8204,9 @@
             }
         },
         "node_modules/svelte-check": {
-            "version": "3.4.5",
-            "resolved": "https://registry.npmjs.org/svelte-check/-/svelte-check-3.4.5.tgz",
-            "integrity": "sha512-FsD/CUVdEI0F9sfylh1Fe15kDjvvbyBxzDpACPsdq0EASgaZukBXaMXofpxlgmWsgVET3OynMQlbtUQoWCz9Rw==",
+            "version": "3.5.1",
+            "resolved": "https://registry.npmjs.org/svelte-check/-/svelte-check-3.5.1.tgz",
+            "integrity": "sha512-+Zb4iHxAhdUtcUg/WJPRjlS1RJalIsWAe9Mz6G1zyznSs7dDkT7VUBdXc3q7Iwg49O/VrZgyJRvOJkjuBfKjFA==",
             "dev": true,
             "dependencies": {
                 "@jridgewell/trace-mapping": "^0.3.17",
@@ -8215,7 +8215,7 @@
                 "import-fresh": "^3.2.1",
                 "picocolors": "^1.0.0",
                 "sade": "^1.7.4",
-                "svelte-preprocess": "^5.0.3",
+                "svelte-preprocess": "^5.0.4",
                 "typescript": "^5.0.3"
             },
             "bin": {
@@ -8561,9 +8561,9 @@
             }
         },
         "node_modules/tslib": {
-            "version": "2.6.0",
-            "resolved": "https://registry.npmjs.org/tslib/-/tslib-2.6.0.tgz",
-            "integrity": "sha512-7At1WUettjcSRHXCyYtTselblcHl9PJFFVKiCAy/bY97+BPZXSQ2wbq0P9s8tK2G7dFQfNnlJnPAiArVBVBsfA=="
+            "version": "2.6.2",
+            "resolved": "https://registry.npmjs.org/tslib/-/tslib-2.6.2.tgz",
+            "integrity": "sha512-AEYxH93jGFPn/a2iVAwW87VuUIkR1FVUKB77NwMF7nBTDkDrrT/Hpt/IrCJ0QXhW27jTBDcf5ZY7w6RiqTMw2Q=="
         },
         "node_modules/tsutils": {
             "version": "3.21.0",
@@ -8626,9 +8626,9 @@
             "dev": true
         },
         "node_modules/typescript": {
-            "version": "5.1.6",
-            "resolved": "https://registry.npmjs.org/typescript/-/typescript-5.1.6.tgz",
-            "integrity": "sha512-zaWCozRZ6DLEWAWFrVDz1H6FVXzUSfTy5FUMWsQlU8Ym5JP9eO4xkTIROFCQvhQf61z6O/G6ugw3SgAnvvm+HA==",
+            "version": "5.2.2",
+            "resolved": "https://registry.npmjs.org/typescript/-/typescript-5.2.2.tgz",
+            "integrity": "sha512-mI4WrpHsbCIcwT9cF4FZvr80QUeKvsUsUvKDoR+X/7XHQH98xYD8YHZg7ANtz2GtZt/CBq2QJ0thkGJMHfqc1w==",
             "dev": true,
             "bin": {
                 "tsc": "bin/tsc",
@@ -15451,9 +15451,9 @@
             }
         },
         "svelte-check": {
-            "version": "3.4.5",
-            "resolved": "https://registry.npmjs.org/svelte-check/-/svelte-check-3.4.5.tgz",
-            "integrity": "sha512-FsD/CUVdEI0F9sfylh1Fe15kDjvvbyBxzDpACPsdq0EASgaZukBXaMXofpxlgmWsgVET3OynMQlbtUQoWCz9Rw==",
+            "version": "3.5.1",
+            "resolved": "https://registry.npmjs.org/svelte-check/-/svelte-check-3.5.1.tgz",
+            "integrity": "sha512-+Zb4iHxAhdUtcUg/WJPRjlS1RJalIsWAe9Mz6G1zyznSs7dDkT7VUBdXc3q7Iwg49O/VrZgyJRvOJkjuBfKjFA==",
             "dev": true,
             "requires": {
                 "@jridgewell/trace-mapping": "^0.3.17",
@@ -15462,7 +15462,7 @@
                 "import-fresh": "^3.2.1",
                 "picocolors": "^1.0.0",
                 "sade": "^1.7.4",
-                "svelte-preprocess": "^5.0.3",
+                "svelte-preprocess": "^5.0.4",
                 "typescript": "^5.0.3"
             }
         },
@@ -15675,9 +15675,9 @@
             }
         },
         "tslib": {
-            "version": "2.6.0",
-            "resolved": "https://registry.npmjs.org/tslib/-/tslib-2.6.0.tgz",
-            "integrity": "sha512-7At1WUettjcSRHXCyYtTselblcHl9PJFFVKiCAy/bY97+BPZXSQ2wbq0P9s8tK2G7dFQfNnlJnPAiArVBVBsfA=="
+            "version": "2.6.2",
+            "resolved": "https://registry.npmjs.org/tslib/-/tslib-2.6.2.tgz",
+            "integrity": "sha512-AEYxH93jGFPn/a2iVAwW87VuUIkR1FVUKB77NwMF7nBTDkDrrT/Hpt/IrCJ0QXhW27jTBDcf5ZY7w6RiqTMw2Q=="
         },
         "tsutils": {
             "version": "3.21.0",
@@ -15724,9 +15724,9 @@
             "dev": true
         },
         "typescript": {
-            "version": "5.1.6",
-            "resolved": "https://registry.npmjs.org/typescript/-/typescript-5.1.6.tgz",
-            "integrity": "sha512-zaWCozRZ6DLEWAWFrVDz1H6FVXzUSfTy5FUMWsQlU8Ym5JP9eO4xkTIROFCQvhQf61z6O/G6ugw3SgAnvvm+HA==",
+            "version": "5.2.2",
+            "resolved": "https://registry.npmjs.org/typescript/-/typescript-5.2.2.tgz",
+            "integrity": "sha512-mI4WrpHsbCIcwT9cF4FZvr80QUeKvsUsUvKDoR+X/7XHQH98xYD8YHZg7ANtz2GtZt/CBq2QJ0thkGJMHfqc1w==",
             "dev": true
         },
         "ufo": {
diff --git a/package.json b/package.json
index 5600d258b..309c28cda 100644
--- a/package.json
+++ b/package.json
@@ -64,11 +64,11 @@
         "prettier-plugin-svelte": "^3.0.3",
         "sass": "^1.59.3",
         "svelte": "^4.2.0",
-        "svelte-check": "^3.4.3",
+        "svelte-check": "^3.5.1",
         "svelte-jester": "^2.3.2",
-        "svelte-preprocess": "^5.0.3",
-        "tslib": "^2.5.0",
-        "typescript": "^5.0.2",
+        "svelte-preprocess": "^5.0.4",
+        "tslib": "^2.6.2",
+        "typescript": "^5.2.2",
         "vite": "^4.4.9",
         "vitest": "^0.29.7"
     },
diff --git a/src/lib/components/feedback/evaluation.svelte b/src/lib/components/feedback/evaluation.svelte
index b26331304..96956714c 100644
--- a/src/lib/components/feedback/evaluation.svelte
+++ b/src/lib/components/feedback/evaluation.svelte
@@ -1,6 +1,4 @@
 <script lang="ts">
-    import { clickOnEnter } from '$lib/helpers/a11y';
-
     export let value: number = null;
 </script>
 
@@ -9,9 +7,10 @@
         <slot />
     </legend>
     <ul class="u-flex u-main-space-between u-margin-block-start-16">
-        {#each Array(10) as _, i}
-            <li on:keyup={clickOnEnter} on:click={() => (value = i)}>
+        {#each Array(11) as _, i}
+            <li>
                 <input
+                    on:click={() => (value = i)}
                     type="radio"
                     name="recommend"
                     class="radio-button"
diff --git a/src/lib/components/feedback/feedbackNPS.svelte b/src/lib/components/feedback/feedbackNPS.svelte
index 613e10514..e0ce7731f 100644
--- a/src/lib/components/feedback/feedbackNPS.svelte
+++ b/src/lib/components/feedback/feedbackNPS.svelte
@@ -2,6 +2,8 @@
     import { FormList, InputTextarea, InputText, InputEmail } from '$lib/elements/forms';
     import { feedbackData } from '$lib/stores/feedback';
     import Evaluation from './evaluation.svelte';
+
+    $: console.log($feedbackData);
 </script>
 
 <Evaluation bind:value={$feedbackData.value}>
diff --git a/src/lib/elements/forms/inputFile.svelte b/src/lib/elements/forms/inputFile.svelte
index eb09785bd..013e73f87 100644
--- a/src/lib/elements/forms/inputFile.svelte
+++ b/src/lib/elements/forms/inputFile.svelte
@@ -98,6 +98,7 @@
         </Label>
     {/if}
     <div
+        role="region"
         class="box is-no-shadow u-padding-24"
         style="--box-border-radius:var(--border-radius-xsmall); z-index: 1"
         class:u-margin-block-start-8={!!label}
diff --git a/src/lib/elements/forms/inputSelectSearch.svelte b/src/lib/elements/forms/inputSelectSearch.svelte
index b5ead1e7e..ae3fcd638 100644
--- a/src/lib/elements/forms/inputSelectSearch.svelte
+++ b/src/lib/elements/forms/inputSelectSearch.svelte
@@ -128,6 +128,8 @@
             <div class="input-text-wrapper" style="--amount-of-buttons:2">
                 {#if $$slots.output && selectedOption}
                     <div
+                        role="button"
+                        tabindex="0"
                         on:keyup={clickOnEnter}
                         on:click={() => {
                             if (interactiveOutput) hasFocus = !hasFocus;
diff --git a/src/lib/elements/forms/inputTextarea.svelte b/src/lib/elements/forms/inputTextarea.svelte
index e7719d17d..fa4e76837 100644
--- a/src/lib/elements/forms/inputTextarea.svelte
+++ b/src/lib/elements/forms/inputTextarea.svelte
@@ -62,7 +62,7 @@
         {label}
     </Label>
 
-    <div class="input-text-wrapper" on:click on:keyup={clickOnEnter}>
+    <div class="input-text-wrapper" on:click on:keyup={clickOnEnter} role="textbox" tabindex="-1">
         <textarea
             {id}
             {name}
diff --git a/src/lib/elements/table/cellCheck.svelte b/src/lib/elements/table/cellCheck.svelte
index 4f73f4a69..d557e6da3 100644
--- a/src/lib/elements/table/cellCheck.svelte
+++ b/src/lib/elements/table/cellCheck.svelte
@@ -24,7 +24,12 @@
 </script>
 
 <TableCell class="u-position-relative">
-    <div class="touch-area" on:click={handleClick} on:keypress={handleClick} />
+    <div
+        class="touch-area"
+        role="button"
+        tabindex="-1"
+        on:click={handleClick}
+        on:keypress={handleClick} />
     <InputCheckbox
         bind:element={el}
         id="select-{id}"
diff --git a/src/lib/stores/feedback.ts b/src/lib/stores/feedback.ts
index e33470f50..86bf6ccae 100644
--- a/src/lib/stores/feedback.ts
+++ b/src/lib/stores/feedback.ts
@@ -24,7 +24,7 @@ export type FeedbackOption = {
     type: Feedback['type'];
     title: string;
     desc: string;
-    component: typeof SvelteComponent<any>;
+    component: typeof SvelteComponent<unknown>;
 };
 
 export const feedbackOptions: FeedbackOption[] = [
@@ -45,13 +45,14 @@ export const feedbackOptions: FeedbackOption[] = [
 export const selectedFeedback = writable<FeedbackOption>();
 
 function createFeedbackDataStore() {
-    const { subscribe, update } = writable<FeedbackData>({
+    const { set, subscribe, update } = writable<FeedbackData>({
         message: '',
         name: '',
         email: '',
         value: 0
     });
     return {
+        set,
         subscribe,
         update,
         reset: () => {
diff --git a/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/attributes/relationship.svelte b/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/attributes/relationship.svelte
index dcd45feea..d322ff2f7 100644
--- a/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/attributes/relationship.svelte
+++ b/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/attributes/relationship.svelte
@@ -160,7 +160,7 @@
     <SelectSearchItem data={o.data}>
         {o.label}
     </SelectSearchItem>
-    <svelte:fragment slot="output">
+    <svelte:fragment slot="output" let:option={o}>
         <output class="input-text" class:is-read-only={editing}>
             <SelectSearchItem data={o.data}>
                 {o.label}
diff --git a/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/document-[document]/attributes/relationship.svelte b/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/document-[document]/attributes/relationship.svelte
index c9bf71b4f..dd7035578 100644
--- a/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/document-[document]/attributes/relationship.svelte
+++ b/src/routes/console/project-[project]/databases/database-[database]/collection-[collection]/document-[document]/attributes/relationship.svelte
@@ -131,7 +131,7 @@
                             <SelectSearchItem data={o.data}>
                                 {o.label}
                             </SelectSearchItem>
-                            <svelte:fragment slot="output">
+                            <svelte:fragment slot="output" let:option={o}>
                                 <output class="input-text is-read-only">
                                     <SelectSearchItem data={o.data}>
                                         {o.label}
@@ -173,7 +173,7 @@
                         <SelectSearchItem data={o.data}>
                             {o.label}
                         </SelectSearchItem>
-                        <svelte:fragment slot="output">
+                        <svelte:fragment slot="output" let:option={o}>
                             <output class="input-text is-read-only">
                                 <SelectSearchItem data={o.data}>
                                     {o.label}
@@ -205,7 +205,7 @@
                             <SelectSearchItem data={o.data}>
                                 {o.label}
                             </SelectSearchItem>
-                            <svelte:fragment slot="output">
+                            <svelte:fragment slot="output" let:option={o}>
                                 <output class="input-text is-read-only">
                                     <SelectSearchItem data={o.data}>
                                         {o.label}
@@ -265,7 +265,7 @@
         <SelectSearchItem data={o.data}>
             {o.label}
         </SelectSearchItem>
-        <svelte:fragment slot="output">
+        <svelte:fragment slot="output" let:option={o}>
             <output class="input-text">
                 <SelectSearchItem data={o.data}>
                     {o.label}