From 2583b7bd49d75bc59cdd88178680ed64a92cccbc Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Mon, 22 Sep 2025 14:03:23 +0530 Subject: [PATCH 1/6] fix: correct spreadsheetRenderKey update in CSV import completion --- src/lib/components/csvImportBox.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/components/csvImportBox.svelte b/src/lib/components/csvImportBox.svelte index 8ff2838ab..9643afdb1 100644 --- a/src/lib/components/csvImportBox.svelte +++ b/src/lib/components/csvImportBox.svelte @@ -62,7 +62,7 @@ if (isSuccess) { await invalidate(Dependencies.ROWS); - $spreadsheetRenderKey = hash(Date.now().toString()); + spreadsheetRenderKey.set(hash(Date.now().toString())); } } From a4fa521fb20bce264a00d55e030ae60454c54e0e Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Mon, 22 Sep 2025 14:38:36 +0530 Subject: [PATCH 2/6] fix: drop stale items --- src/lib/components/csvImportBox.svelte | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/lib/components/csvImportBox.svelte b/src/lib/components/csvImportBox.svelte index 9643afdb1..0716e5990 100644 --- a/src/lib/components/csvImportBox.svelte +++ b/src/lib/components/csvImportBox.svelte @@ -75,6 +75,7 @@ const current = $importItems.get(importData.$id); let tableName = current?.table ?? null; + let resourceMissing = false; if (!tableName && tableId) { try { @@ -87,9 +88,19 @@ tableName = table.name; } catch { tableName = null; + resourceMissing = true; } } + if (resourceMissing) { + importItems.update((items) => { + const next = new Map(items); + next.delete(importData.$id); + return next; + }); + return; + } + importItems.update((items) => { const existing = items.get(importData.$id); From 8254191cc9161e1a151b5f18ab22f5f107badf6c Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Mon, 22 Sep 2025 15:46:02 +0530 Subject: [PATCH 3/6] remove resourcemissing and using tableName is null --- src/lib/components/csvImportBox.svelte | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/lib/components/csvImportBox.svelte b/src/lib/components/csvImportBox.svelte index 0716e5990..15b5b1e96 100644 --- a/src/lib/components/csvImportBox.svelte +++ b/src/lib/components/csvImportBox.svelte @@ -75,7 +75,6 @@ const current = $importItems.get(importData.$id); let tableName = current?.table ?? null; - let resourceMissing = false; if (!tableName && tableId) { try { @@ -88,11 +87,10 @@ tableName = table.name; } catch { tableName = null; - resourceMissing = true; } } - if (resourceMissing) { + if (tableName === null) { importItems.update((items) => { const next = new Map(items); next.delete(importData.$id); From 1d134715296d54fbda4e4a0195b5646b0ad070c4 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Mon, 22 Sep 2025 15:49:02 +0530 Subject: [PATCH 4/6] used table id aswell as safe check --- src/lib/components/csvImportBox.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/components/csvImportBox.svelte b/src/lib/components/csvImportBox.svelte index 15b5b1e96..ec7a2c9a3 100644 --- a/src/lib/components/csvImportBox.svelte +++ b/src/lib/components/csvImportBox.svelte @@ -90,7 +90,7 @@ } } - if (tableName === null) { + if (tableId && tableName === null) { importItems.update((items) => { const next = new Map(items); next.delete(importData.$id); From 2ce54049d8ae7b0a605ae81384bb1aabbfc6aadb Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Mon, 22 Sep 2025 15:54:29 +0530 Subject: [PATCH 5/6] remove table id --- src/lib/components/csvImportBox.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/components/csvImportBox.svelte b/src/lib/components/csvImportBox.svelte index ec7a2c9a3..15b5b1e96 100644 --- a/src/lib/components/csvImportBox.svelte +++ b/src/lib/components/csvImportBox.svelte @@ -90,7 +90,7 @@ } } - if (tableId && tableName === null) { + if (tableName === null) { importItems.update((items) => { const next = new Map(items); next.delete(importData.$id); From e50ee41714e2f6807db888106496e0d505d0efa4 Mon Sep 17 00:00:00 2001 From: Harsh Mahajan <127186841+HarshMN2345@users.noreply.github.com> Date: Mon, 22 Sep 2025 15:58:15 +0530 Subject: [PATCH 6/6] Update src/lib/components/csvImportBox.svelte Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- src/lib/components/csvImportBox.svelte | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/components/csvImportBox.svelte b/src/lib/components/csvImportBox.svelte index 15b5b1e96..ec7a2c9a3 100644 --- a/src/lib/components/csvImportBox.svelte +++ b/src/lib/components/csvImportBox.svelte @@ -90,7 +90,7 @@ } } - if (tableName === null) { + if (tableId && tableName === null) { importItems.update((items) => { const next = new Map(items); next.delete(importData.$id);