From 32714fcfa579c05fc5f9bbe67d82c0d2788539f3 Mon Sep 17 00:00:00 2001
From: Damodar Lohani
Date: Tue, 21 Feb 2023 02:34:13 +0000
Subject: [PATCH 01/22] update password history limit component
---
src/lib/actions/analytics.ts | 1 +
.../auth/security/+page.svelte | 2 +
.../security/updatePasswordHistory.svelte | 64 +++++++++++++++++++
3 files changed, 67 insertions(+)
create mode 100644 src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte
diff --git a/src/lib/actions/analytics.ts b/src/lib/actions/analytics.ts
index 357b5ff55..501da65d5 100644
--- a/src/lib/actions/analytics.ts
+++ b/src/lib/actions/analytics.ts
@@ -141,6 +141,7 @@ export enum Submit {
TeamUpdateName = 'submit_team_update_name',
AuthLimitUpdate = 'submit_auth_limit_update',
AuthStatusUpdate = 'submit_auth_status_update',
+ AuthPasswordHistoryUpdate = 'submit_auth_password_history_limit_update',
SessionsLengthUpdate = 'submit_sessions_length_update',
SessionsLimitUpdate = 'submit_sessions_limit_update',
SessionDelete = 'submit_session_delete',
diff --git a/src/routes/console/project-[project]/auth/security/+page.svelte b/src/routes/console/project-[project]/auth/security/+page.svelte
index beea9ce44..904d7a71f 100644
--- a/src/routes/console/project-[project]/auth/security/+page.svelte
+++ b/src/routes/console/project-[project]/auth/security/+page.svelte
@@ -1,5 +1,6 @@
+
+
From 42f484db57bd308e264bdea5f10888024cad782b Mon Sep 17 00:00:00 2001
From: Damodar Lohani
Date: Tue, 21 Feb 2023 09:18:38 +0545
Subject: [PATCH 02/22] remove unused code
---
.../auth/security/updatePasswordHistory.svelte | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte b/src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte
index 1bd239ff9..f4496612a 100644
--- a/src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte
+++ b/src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte
@@ -3,15 +3,12 @@
import { Submit, trackError, trackEvent } from '$lib/actions/analytics';
import { CardGrid, Heading } from '$lib/components';
import { Dependencies } from '$lib/constants';
- import { Button, Form, InputNumber, InputSelect } from '$lib/elements/forms';
- import { createTimeUnitPair } from '$lib/helpers/unit';
+ import { Button, Form, InputNumber } from '$lib/elements/forms';
import { addNotification } from '$lib/stores/notifications';
import { sdkForConsole } from '$lib/stores/sdk';
import { project } from '../../store';
const projectId = $project.$id;
- const { value, unit, baseValue, units } = createTimeUnitPair($project.authDuration);
- const options = units.map((v) => ({ label: v.name, value: v.name }));
let passwordHistory = $project.authPasswordHistory ?? 0;
async function updatePasswordHistoryLimit() {
From a2020ca25f8ba5b18beaac0df23a6acbdcebbc72 Mon Sep 17 00:00:00 2001
From: Damodar Lohani
Date: Tue, 21 Feb 2023 09:31:35 +0545
Subject: [PATCH 03/22] password dictonary UI
---
src/lib/actions/analytics.ts | 1 +
.../auth/security/+page.svelte | 2 +
.../security/updatePasswordDictionary.svelte | 68 +++++++++++++++++++
3 files changed, 71 insertions(+)
create mode 100644 src/routes/console/project-[project]/auth/security/updatePasswordDictionary.svelte
diff --git a/src/lib/actions/analytics.ts b/src/lib/actions/analytics.ts
index 501da65d5..397e0d60d 100644
--- a/src/lib/actions/analytics.ts
+++ b/src/lib/actions/analytics.ts
@@ -142,6 +142,7 @@ export enum Submit {
AuthLimitUpdate = 'submit_auth_limit_update',
AuthStatusUpdate = 'submit_auth_status_update',
AuthPasswordHistoryUpdate = 'submit_auth_password_history_limit_update',
+ AuthPasswordDictionaryUpdate = 'submit_auth_password_dictionary_update',
SessionsLengthUpdate = 'submit_sessions_length_update',
SessionsLimitUpdate = 'submit_sessions_limit_update',
SessionDelete = 'submit_session_delete',
diff --git a/src/routes/console/project-[project]/auth/security/+page.svelte b/src/routes/console/project-[project]/auth/security/+page.svelte
index 904d7a71f..c9c411910 100644
--- a/src/routes/console/project-[project]/auth/security/+page.svelte
+++ b/src/routes/console/project-[project]/auth/security/+page.svelte
@@ -1,5 +1,6 @@
+
+
From e3cad8e5106a9ad1642ebdc5a1cf2849cf705472 Mon Sep 17 00:00:00 2001
From: Damodar Lohani
Date: Tue, 21 Feb 2023 10:43:22 +0545
Subject: [PATCH 04/22] Update
src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte
Co-authored-by: Carla
---
.../auth/security/updatePasswordHistory.svelte | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte b/src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte
index f4496612a..2471c24e0 100644
--- a/src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte
+++ b/src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte
@@ -45,7 +45,7 @@
Password History
- Maximum nubmer of password history to save for a user. 0 for disabling the password
+ Maximum number of passwords saved per user. Use 0 to disable the password
history.
From 09898293997a02048e97eb554b545a93cef0b59d Mon Sep 17 00:00:00 2001
From: Damodar Lohani
Date: Tue, 21 Feb 2023 08:40:41 +0000
Subject: [PATCH 05/22] review feedbacks
---
.../security/updatePasswordDictionary.svelte | 9 ++++++--
.../security/updatePasswordHistory.svelte | 21 ++++++++++++++-----
2 files changed, 23 insertions(+), 7 deletions(-)
diff --git a/src/routes/console/project-[project]/auth/security/updatePasswordDictionary.svelte b/src/routes/console/project-[project]/auth/security/updatePasswordDictionary.svelte
index 95c826f50..839b0f2fe 100644
--- a/src/routes/console/project-[project]/auth/security/updatePasswordDictionary.svelte
+++ b/src/routes/console/project-[project]/auth/security/updatePasswordDictionary.svelte
@@ -6,10 +6,15 @@
import { Button, Form, FormList, InputNumber, InputSwitch } from '$lib/elements/forms';
import { addNotification } from '$lib/stores/notifications';
import { sdkForConsole } from '$lib/stores/sdk';
+ import { onMount } from 'svelte';
import { project } from '../../store';
const projectId = $project.$id;
- let passwordDictionary = $project.authPasswordDictionary ?? 0;
+ let passwordDictionary = $project.authPasswordDictionary ?? false;
+
+ onMount(() => {
+ passwordDictionary = $project.authPasswordDictionary ?? false;
+ });
async function updatePasswordDictionary() {
try {
@@ -56,7 +61,7 @@
used password. It uses 10 K most common passwords list.
+ >10K most common passwords list.
diff --git a/src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte b/src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte
index 2471c24e0..dcd1b9da6 100644
--- a/src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte
+++ b/src/routes/console/project-[project]/auth/security/updatePasswordHistory.svelte
@@ -4,13 +4,19 @@
import { CardGrid, Heading } from '$lib/components';
import { Dependencies } from '$lib/constants';
import { Button, Form, InputNumber } from '$lib/elements/forms';
+ import FormList from '$lib/elements/forms/formList.svelte';
import { addNotification } from '$lib/stores/notifications';
import { sdkForConsole } from '$lib/stores/sdk';
+ import { onMount } from 'svelte';
import { project } from '../../store';
const projectId = $project.$id;
let passwordHistory = $project.authPasswordHistory ?? 0;
+ onMount(() => {
+ passwordHistory = $project.authPasswordHistory ?? 0;
+ });
+
async function updatePasswordHistoryLimit() {
try {
const path = '/projects/' + projectId + '/auth/password-history';
@@ -44,14 +50,19 @@