From 95e5d10c65a4862c348e129bc120913534e5e7b2 Mon Sep 17 00:00:00 2001 From: Steven Nguyen Date: Wed, 23 Nov 2022 08:39:18 -0800 Subject: [PATCH] Ensure updating function doesn't reset other params For any optional param not sent to the API, the values are reset to the default value. This update ensures we pass the existing values so that they aren't reset. --- .../function-[function]/settings/+page.svelte | 32 ++++++++++++++++--- .../functions/function-[function]/store.ts | 2 +- 2 files changed, 28 insertions(+), 6 deletions(-) diff --git a/src/routes/console/project-[project]/functions/function-[function]/settings/+page.svelte b/src/routes/console/project-[project]/functions/function-[function]/settings/+page.svelte index 29adb4758..9313c97a0 100644 --- a/src/routes/console/project-[project]/functions/function-[function]/settings/+page.svelte +++ b/src/routes/console/project-[project]/functions/function-[function]/settings/+page.svelte @@ -62,7 +62,15 @@ async function updateName() { try { - await sdkForProject.functions.update(functionId, functionName, $func.execute); + await sdkForProject.functions.update( + functionId, + functionName, + $func.execute, + $func.events, + $func.schedule, + $func.timeout, + $func.enabled + ); invalidate(Dependencies.FUNCTION); addNotification({ message: 'Name has been updated', @@ -79,7 +87,15 @@ async function updatePermissions() { try { - await sdkForProject.functions.update(functionId, $func.name, permissions); + await sdkForProject.functions.update( + functionId, + $func.name, + permissions, + $func.events, + $func.schedule, + $func.timeout, + $func.enabled + ); invalidate(Dependencies.FUNCTION); addNotification({ message: 'Permissions have been updated', @@ -100,7 +116,10 @@ functionId, $func.name, $func.execute, - Array.from($eventSet) + Array.from($eventSet), + $func.schedule, + $func.timeout, + $func.enabled ); invalidate(Dependencies.FUNCTION); addNotification({ @@ -124,7 +143,8 @@ $func.execute, $func.events, functionSchedule, - timeout + $func.timeout, + $func.enabled ); invalidate(Dependencies.FUNCTION); @@ -149,9 +169,11 @@ $func.execute, $func.events, $func.schedule, - timeout + timeout, + $func.enabled ); + invalidate(Dependencies.FUNCTION); addNotification({ type: 'success', message: 'Timeout has been updated' diff --git a/src/routes/console/project-[project]/functions/function-[function]/store.ts b/src/routes/console/project-[project]/functions/function-[function]/store.ts index 726e6cd0e..0dd72124b 100644 --- a/src/routes/console/project-[project]/functions/function-[function]/store.ts +++ b/src/routes/console/project-[project]/functions/function-[function]/store.ts @@ -2,5 +2,5 @@ import { page } from '$app/stores'; import { derived, writable, type Writable } from 'svelte/store'; import type { Models } from '@aw-labs/appwrite-console'; -export const func = derived(page, ($page) => $page.data.function); +export const func = derived(page, ($page) => $page.data.function as Models.Function); export const execute: Writable = writable();