From 88df69d795717f8c59a5b4a325dff4c66bba9df6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Matej=20Ba=C4=8Do?= <matejbaco2000@gmail.com>
Date: Mon, 22 Jul 2024 11:13:25 +0000
Subject: [PATCH 1/2] Fix logs copy

---
 .../functions/function-[function]/executions/+page.svelte   | 3 +--
 .../function-[function]/settings/updateLogging.svelte       | 6 +++---
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/routes/(console)/project-[project]/functions/function-[function]/executions/+page.svelte b/src/routes/(console)/project-[project]/functions/function-[function]/executions/+page.svelte
index 0ec996cfb..56dff9540 100644
--- a/src/routes/(console)/project-[project]/functions/function-[function]/executions/+page.svelte
+++ b/src/routes/(console)/project-[project]/functions/function-[function]/executions/+page.svelte
@@ -202,8 +202,7 @@
         <div class="common-section">
             <Alert type="info" isStandalone>
                 <svelte:fragment slot="title">Your execution logs are disabled</svelte:fragment>
-
-                To see the latest execution logs, enable them in your
+                To view execution logs and errors, enable them in your
                 <a
                     href={`${base}/project-${$project.$id}/functions/function-${$func.$id}/settings`}
                     class="link">
diff --git a/src/routes/(console)/project-[project]/functions/function-[function]/settings/updateLogging.svelte b/src/routes/(console)/project-[project]/functions/function-[function]/settings/updateLogging.svelte
index 37da597f9..53cf050e6 100644
--- a/src/routes/(console)/project-[project]/functions/function-[function]/settings/updateLogging.svelte
+++ b/src/routes/(console)/project-[project]/functions/function-[function]/settings/updateLogging.svelte
@@ -69,15 +69,15 @@
     <CardGrid>
         <Heading tag="h6" size="7">Execution logs</Heading>
         <p>
-            Enable or disable execution logs. We recommend disabling logs when transferring critical
-            data or for performance reasons.
+            Enable or disable execution logs. We recommend disabling them for better performance in
+            production.
         </p>
         <svelte:fragment slot="aside">
             <FormList>
                 <InputSwitch label="Logs" id="logging" bind:value={functionLogging}>
                     <svelte:fragment slot="description">
                         <p>
-                            When enabled, all execution responses will be accessible in the <a
+                            When disabled, execution logs and errors will not be shown in the <a
                                 href={`${base}/project-${$project.$id}/functions/function-${$func.$id}/executions`}
                                 class="link">
                                 Executions</a> tab

From 832529514d2ca622c8cda36ba95191f28012f1d8 Mon Sep 17 00:00:00 2001
From: Torsten Dittmann <torsten.dittmann@googlemail.com>
Date: Mon, 22 Jul 2024 16:14:21 +0200
Subject: [PATCH 2/2] tests: fix tab selectors

---
 src/lib/components/secondaryTabsItem.svelte | 1 -
 tests/unit/components/dropTabsItem.test.ts  | 4 ++--
 tests/unit/components/tab.test.ts           | 4 ++--
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/lib/components/secondaryTabsItem.svelte b/src/lib/components/secondaryTabsItem.svelte
index 4107b6b95..a6191f1b1 100644
--- a/src/lib/components/secondaryTabsItem.svelte
+++ b/src/lib/components/secondaryTabsItem.svelte
@@ -28,7 +28,6 @@
         {/if}
     {:else}
         <button
-            role="tab"
             type="button"
             class="secondary-tabs-button"
             class:u-width-full-line={fullWidth}
diff --git a/tests/unit/components/dropTabsItem.test.ts b/tests/unit/components/dropTabsItem.test.ts
index 0fa2c4c12..8e5728df8 100644
--- a/tests/unit/components/dropTabsItem.test.ts
+++ b/tests/unit/components/dropTabsItem.test.ts
@@ -3,10 +3,10 @@ import { vi } from 'vitest';
 import { render, fireEvent } from '@testing-library/svelte';
 import { SecondaryTabsItem } from '../../../src/lib/components';
 
-test('shows button', () => {
+test('shows tab', () => {
     const { getByRole } = render(SecondaryTabsItem);
 
-    expect(getByRole('button')).toBeInTheDocument();
+    expect(getByRole('tab')).toBeInTheDocument();
 });
 
 test('shows link', () => {
diff --git a/tests/unit/components/tab.test.ts b/tests/unit/components/tab.test.ts
index c58e59214..7ad677d2f 100644
--- a/tests/unit/components/tab.test.ts
+++ b/tests/unit/components/tab.test.ts
@@ -11,7 +11,7 @@ test('shows tab', () => {
 test('shows tab - is selected', () => {
     const { getByRole } = render(Tab, { selected: true });
 
-    expect(getByRole('tab')).toHaveClass('is-selected');
+    expect(getByRole('tab').querySelector('button')).toHaveClass('is-selected');
 });
 
 test('shows tab - is link', () => {
@@ -23,7 +23,7 @@ test('shows tab - is link', () => {
 
 test('shows tab - on:click', async () => {
     const { getByRole, component } = render(Tab);
-    const tab = getByRole('tab');
+    const tab = getByRole('tab').querySelector('button');
     const callback = vi.fn();
     component.$on('click', callback);